From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#24833: Hydra ignores MIPS-specific patch for Mesa on core-updates
Date: Thu, 03 Nov 2016 11:29:33 +0100
Message-ID: <87zilgx3ea.fsf@gnu.org>
References: <87ins5le6d.fsf@gnu.org> <87shrdca9s.fsf@netris.org>
	<87eg2ttis5.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1c2FHb-0005s2-4K
	for bug-guix@gnu.org; Thu, 03 Nov 2016 06:30:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1c2FHW-0007N9-Fn
	for bug-guix@gnu.org; Thu, 03 Nov 2016 06:30:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53983)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1c2FHW-0007N0-CQ
	for bug-guix@gnu.org; Thu, 03 Nov 2016 06:30:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1c2FHW-0005R9-6X
	for bug-guix@gnu.org; Thu, 03 Nov 2016 06:30:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.24833.D24833.147816898720849.done@debbugs.gnu.org>
In-Reply-To: <87eg2ttis5.fsf@netris.org> (Mark H. Weaver's message of "Wed, 02
	Nov 2016 22:10:50 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: 24833-done@debbugs.gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s)
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 on core-updates added a
>>> patch to Mesa on MIPS only, in order to prevent unnecessary rebuilds on
>>> other systems.  'guix' running on a MIPS system generates a derivation
>>> that applies the patch, but the derivation generated for MIPS on Hydra
>>> omits the patch.
>>
>> Did it turn out to be the same issue as <http://bugs.gnu.org/24833>, or
>> is it something entirely different?
>
> Bug 24833 is this bug, so yes, by reflexivity it's the same issue, but I
> suspect that's not what you meant to ask :)

Arf, sorry, I meant to ask if this is related to
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24832>.

Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 doesn=E2=80=99t have the de=
sired
effect: the =E2=80=98patches=E2=80=99 field is voluntarily unthunked, so it=
 gets to see
the =E2=80=98%current-system=E2=80=99 value that it gets when gl.scm is loa=
ded, hence
the problem we=E2=80=99re experiencing.

This is fixed in 4c93fe83e89473b2d16b93900c87e0da0ceecd6e by making the
patch an input depending on =E2=80=98%current-system=E2=80=99, within an =
=E2=80=98inputs=E2=80=99 field.

Thanks!

Ludo=E2=80=99.