From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#25101: [PATCH 1/2] gnu: Add hpaio-enabled sane-backends variant. Date: Mon, 12 Dec 2016 23:41:07 +0100 Message-ID: <87zik0wz24.fsf@gnu.org> References: <20161203194113.6456663e@scratchpost.org> <20161204040037.21758-1-ajpatter@uwaterloo.ca> <20161204040037.21758-2-ajpatter@uwaterloo.ca> <871sxm14rf.fsf@gnu.org> <20161205173827.49a9001a@uwaterloo.ca> <87a8c9xw0u.fsf@gnu.org> <20161212151108.5b51103f@uwaterloo.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZIM-0002o6-IN for bug-guix@gnu.org; Mon, 12 Dec 2016 17:42:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZII-0002lw-Hy for bug-guix@gnu.org; Mon, 12 Dec 2016 17:42:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52537) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cGZII-0002lX-Eg for bug-guix@gnu.org; Mon, 12 Dec 2016 17:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cGZII-0003g0-6O for bug-guix@gnu.org; Mon, 12 Dec 2016 17:42:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20161212151108.5b51103f@uwaterloo.ca> (Andy Patterson's message of "Mon, 12 Dec 2016 15:11:08 -0500") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Andy Patterson Cc: 25101@debbugs.gnu.org Andy Patterson skribis: > Hi, and sorry for the late reply. > > On Tue, 06 Dec 2016 10:10:57 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Andy Patterson skribis: >>=20 >> > On Mon, 05 Dec 2016 21:48:36 +0100 >> > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >> >=20=20 >> >> > +(define-public sane-backends+hpaio=20=20=20=20 >> >>=20 >> >> Could you add a comment and a synopsis explaining what=E2=80=99s this= is? >> >>=20=20=20 >> > >> > Sure, is the following patch ok?=20=20 >>=20 >> Yup! >>=20 >> >> > + (package >> >> > + (inherit sane-backends) >> >> > + (name "sane-backends+hpaio") >> >> > + (inputs >> >> > + `(("hplip" ,(@ (gnu packages cups) hplip)) >> >> > + ,@(package-inputs sane-backends)))=20=20=20=20 >> >>=20 >> >> The closure size of this is 290 MiB whereas it=E2=80=99s 87 MiB for >> >> =E2=80=98sane-backends=E2=80=99. I suppose that=E2=80=99s the reason= to keep=E2=80=99em separated? >> >>=20=20 >> > >> > Yeah, and there's also the fact that hplip depends on sane-backends. >> > But this is the reason I didn't change sane-backends into a private >> > variable, and then make this the new sane-backends.=20=20 >>=20 >> Oh right. >>=20 >> One last thing: should we renaming =E2=80=9Csane-backends=E2=80=9D to >> =E2=80=9Csane-backends-minimal=E2=80=9D, and =E2=80=9Csane-backends+hpai= o=E2=80=9D to =E2=80=9Csane-backends=E2=80=9D? > > The current "sane-backends" isn't really minimal, as it includes most > backends. I'm not sure how it's applied elsewhere in Guix though, so > I'll leave it up to you. Right. Well maybe while you=E2=80=99re at it you could make the new =E2=80=98sane-backend-minimal=E2=80=99 more minimal, it would make sense to= me. >> That way all scanners would work out of the box, at the expense of >> extra disk usage, but that is roughly what patch 2/2 does anyway. > > One more patch is required in either case, as hplip would need to use > sane-backends-minimal. Let me know if you'd like me to make this change. Yes please! Thank you! Ludo=E2=80=99.