From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#28157: =?UTF-8?Q?=E2=80=9Cr-minimal=E2=80=9D?= retains no reference to =?UTF-8?Q?=E2=80=9Cwhich=E2=80=9D?= Date: Tue, 22 Aug 2017 16:03:06 +0200 Message-ID: <87ziarvgx1.fsf@elephly.net> References: <87valiwkt9.fsf@elephly.net> <877exwc7eh.fsf@gnu.org> <8760dgvu1a.fsf@elephly.net> <87o9r87xhx.fsf@gnu.org> <871so3x3uo.fsf@elephly.net> <878tib4t5n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk9mn-0000ms-T5 for bug-guix@gnu.org; Tue, 22 Aug 2017 10:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dk9mk-000067-PI for bug-guix@gnu.org; Tue, 22 Aug 2017 10:04:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dk9mk-00005o-Lr for bug-guix@gnu.org; Tue, 22 Aug 2017 10:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dk9mk-0006fB-DT for bug-guix@gnu.org; Tue, 22 Aug 2017 10:04:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <878tib4t5n.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28157@debbugs.gnu.org Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> Here’s a patch: > > That was fast. :-) > >> From bbacb223cbd6f1ba0ca77eda9d168e325537e3f3 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Tue, 22 Aug 2017 12:59:48 +0200 >> Subject: [PATCH] gnu: r-minimal: Do not compress serialized files. >> >> * gnu/packages/statistics.scm (r-minimal)[arguments]: Replace build phase >> "patch-which" with "do-not-compress-serialized-files". >> [propagated-inputs]: Move "which" from here... >> [inputs]: ...to here. > > [...] > >> (modify-phases %standard-phases >> ;; FIXME: see bug #28157. >> - (add-before 'configure 'patch-which >> + (add-before 'configure 'do-not-compress-serialized-files >> (lambda* (#:key inputs #:allow-other-keys) >> - (substitute* "src/library/base/R/unix/system.unix.R" >> - (("@WHICH@") "which")) > > Shouldn’t we keep the ‘patch-which’ phase? I don’t think so. I only added this to work around the bug. By default it does the right thing and embeds the full path to “which” (at configure time) in the library. Since the binaries are now uncompressed, the references are visible to Guix, so we should keep the reference instead of just a dangling pointer to “which”, in my opinion. >> + (substitute* "src/library/base/makebasedb.R" >> + (("compress = TRUE") "compress = FALSE")) > > Perhaps move the comment about this bug right above this, so we know why > we don’t compress. Otherwise LGTM! Okay! > Any idea how much extra storage this incurs on disk? The previous “r-minimal”: total: 607.6 MiB The new one: total: 611.2 MiB -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net