From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#29177: Hidden packages are not accounted for by `guix refresh`
Date: Mon, 06 Nov 2017 23:16:46 +0100
Message-ID: <87zi7zm4s1.fsf@gnu.org>
References: <87h8u73zja.fsf@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59318)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eBpha-0004hy-7y
	for bug-guix@gnu.org; Mon, 06 Nov 2017 17:17:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eBphW-00020L-Vp
	for bug-guix@gnu.org; Mon, 06 Nov 2017 17:17:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:46091)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eBphW-00020F-Rv
	for bug-guix@gnu.org; Mon, 06 Nov 2017 17:17:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eBphW-0002j5-II
	for bug-guix@gnu.org; Mon, 06 Nov 2017 17:17:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.29177.B29177.151000661410000@debbugs.gnu.org>
In-Reply-To: <87h8u73zja.fsf@fastmail.com> (Marius Bakke's message of "Mon, 06
	Nov 2017 21:47:21 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29177@debbugs.gnu.org

Hi Marius,

Marius Bakke <mbakke@fastmail.com> skribis:

> Currently, some packages are marked as "hidden".  This makes `guix
> refresh` fail to realize the full impact of a change.  Most notably this
> affects 'xorg-server': there have already been a few commits that
> rebuilds the for-test variant (and thus GTK) because they seemed to only
> cause ~150 rebuilds, where in reality it's more than 400:
>
> 97ecd75e289d96a8b4f9b1ae877d9d1a2f6774b4 gnu: libxfont: Fix CVE-2017-1372=
0, CVE-2017-13722.
> c2eb8cd98c82277e851eb4302b7f12614e215a76 gnu: xorg-server: Build reproduc=
ibly.
> 9371600ec8397ab3d596dea89c388b4acb1c2437 gnu: libxres: Update to 1.2.0.

Oooops!  I=E2=80=99m the guilty party here.  The real dependency count can =
be
found with:

--8<---------------cut here---------------start------------->8---
$ guix refresh -l -e '(@ (gnu packages xorg) xorg-server-1.19.3)' xorg-serv=
er
Building the following 276 packages would ensure 516 dependent packages are=
 rebuilt: snd@17.7 ardour@5.12 =E2=80=A6
--8<---------------cut here---------------end--------------->8---

The problem is not that =E2=80=98xorg-server-1.19.3=E2=80=99 is hidden (we =
can work
around it with -e), but that it inherits from =E2=80=98xorg-server=E2=80=99=
, and thus
ended up being rebuilt.

That=E2=80=99s a =E2=80=9Cknown limitation=E2=80=9D of =E2=80=98guix refres=
h -l=E2=80=99 and not something
easily addressed since inheritance is purely syntactic.  Tricky!

So I think it=E2=80=99s =E2=80=9Cnot a bug=E2=80=9D from the =E2=80=98guix =
refresh=E2=80=99 viewpoint, but it=E2=80=99s
definitely a mistake on my side.  Apologies!

I think at this stage it=E2=80=99s no longer useful to revert this commit
though.  WDYT?

Thanks for the heads-up!

Ludo=E2=80=99.