unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Famulari <leo@famulari.name>
Cc: 30415@debbugs.gnu.org
Subject: bug#30415: Unzip CVE-2018-1000031 and others
Date: Tue, 13 Feb 2018 09:01:44 +0100	[thread overview]
Message-ID: <87zi4djp1z.fsf@elephly.net> (raw)
In-Reply-To: <20180212185802.GA30991@jasmine.lan>


Hi Leo,

> The researcher's advisory recommends building UnZip with FORTIFY_SOURCE
> to reduce the impact of the bug. The attached patch does that.
[…]
> +                 ;; Mitigate CVE-2018-1000035, an exploitable buffer overflow.
> +                 ;; This environment variable is recommended in 'unix/Makefile'
> +                 ;; for passing flags to the C compiler.
> +                 (setenv "LOCAL_UNZIP" "-D_FORTIFY_SOURCE=1")
> +                 #t))))))))

This looks good to me.  Thank you!

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  reply	other threads:[~2018-02-14 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10 18:57 bug#30415: Unzip CVE-2018-1000031 and others Leo Famulari
2018-02-11 15:09 ` Leo Famulari
2018-02-11 15:35 ` Leo Famulari
2018-02-12 18:58   ` Leo Famulari
2018-02-13  8:01     ` Ricardo Wurmus [this message]
2018-02-13 14:51       ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi4djp1z.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=30415@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).