From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#19973: Grafts break debug outputs Date: Thu, 23 Aug 2018 17:47:43 +0200 Message-ID: <87zhxdkrts.fsf@gnu.org> References: <878ufh71do.fsf@netris.org> <87a88wrbvk.fsf@gnu.org> <87pnybmoey.fsf@gnu.org> <87a7pea46g.fsf@ngyro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsrq6-0003aS-Rh for bug-guix@gnu.org; Thu, 23 Aug 2018 11:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsrq6-0007sH-0f for bug-guix@gnu.org; Thu, 23 Aug 2018 11:48:02 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsrq5-0007s5-Rd for bug-guix@gnu.org; Thu, 23 Aug 2018 11:48:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fsrq5-0007ng-P0 for bug-guix@gnu.org; Thu, 23 Aug 2018 11:48:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87a7pea46g.fsf@ngyro.com> (Timothy Sample's message of "Wed, 22 Aug 2018 10:04:07 -0400") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Timothy Sample Cc: 19973@debbugs.gnu.org Hello Timothy, Timothy Sample skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >> Next we can fix build IDs similarly (see ), >> and maybe the Racket CRC issue that Timothy and Chris looked at >> recently, and maybe the Java manifest issue as well (is it still >> relevant?). > > The only concern I have is the level at which the hooks operate. In my > draft patch=C2=B9 I had the hooks running both on the client side and the > build side. This made it possible to get a bit more information about > the derivation being grafted. If everything happens at the build level > based on outputs, we will only be able to look at the structures and > names of the outputs. Yes, I agree that your proposal had the appeal of being possibly more extensible that what I posted here. However, as I wrote there, there are hooks that we=E2=80=99ll always want to run, independently of the input packages, such as the .gnu_debuglink and build-ID hooks; also, it costs nothing to have them unconditionally, we only pay for their functionality when candidate files exist. > That being said, this is probably okay. The Racket hook will just have > to check for =E2=80=9Cshare/racket=E2=80=9D to determine if it runs (and = fail safely if > anything is amiss). Yes, that should work well enough. Thanks for your feedback! Ludo=E2=80=99.