From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#33300: hplip 3.18.9 contains non-free binary blobs Date: Wed, 07 Nov 2018 15:41:28 +0100 Message-ID: <87zhult0fb.fsf@gnu.org> References: <87sh0dur48.fsf@gnu.org> <875zx9dof1.fsf@nckx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKP1y-00022C-5U for bug-guix@gnu.org; Wed, 07 Nov 2018 09:42:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKP1w-0004vC-4H for bug-guix@gnu.org; Wed, 07 Nov 2018 09:42:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:34025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKP1u-0004uX-Gt for bug-guix@gnu.org; Wed, 07 Nov 2018 09:42:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKP1u-0005HH-EA for bug-guix@gnu.org; Wed, 07 Nov 2018 09:42:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <875zx9dof1.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 07 Nov 2018 14:09:54 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Tobias Geerinckx-Rice Cc: 33300@debbugs.gnu.org Hi! Tobias Geerinckx-Rice skribis: > Ludovic Court=C3=A8s wrote: >> I tried removing them with a snippet (patch attached), but >> installation >> eventually fails while trying to link against libImageProcessor, >> which >> is now missing. > > If I correctly read the Debian maintainer's post in the bug you > linked[0], it's possible to revert only the libImageProcessor > infec^Waddition. If it's all right with everyone, I'd like to give > that a try first. Indeed, the Debian patch Efraim linked to does exactly that. So it should be easy to solve. Let=E2=80=99s see if Efraim or another one of us = can get it done soon! > Aside, -ish: looks like most distributions there found out about this > file due to some failing sanity check. Perhaps we could add our own, > in =E2=80=98guix lint=E2=80=99 or at build time, to warn about ELF files = and other > suspicious binaries in post-snippet sourceballs? Commit b17004f9f9541acbd07b45e35222e431427bfde0 added a -Wl,-rpath flag; perhaps that was due to address an error in libImageProcessor.so detected by =E2=80=98validate-runpath=E2=80=99? That said, we could have a post-unpack phase that fails when ELF files are found. The problem is that there are exceptions, in particular =E2=80=9Cyogurt software=E2=80=9D (compilers, mostly). So we=E2=80=99d hav= e to manually fix every exception. > No idea if it's worth the trouble/performance hit/false-positive rate, > of course. That's for the ner^Wgods to decide. Yeah I wonder if it would be fruitful. Ludo=E2=80=99.