From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#33300: Automatically detecting binaries in source tarballs
Date: Sun, 11 Nov 2018 18:28:54 +0100
Message-ID: <87zhufplpl.fsf@gnu.org>
References: <87sh0dur48.fsf@gnu.org> <875zx9dof1.fsf@nckx>
	<87zhult0fb.fsf@gnu.org> <20181108005701.2e76fd3d@scratchpost.org>
	<87y3a454xc.fsf@gnu.org> <20181109001134.3cccd949@alma-ubu>
	<20181111072334.GF1206@macbook41>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLtYi-0005Jj-21
	for bug-guix@gnu.org; Sun, 11 Nov 2018 12:30:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLtYh-0008Mx-5w
	for bug-guix@gnu.org; Sun, 11 Nov 2018 12:30:04 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42426)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gLtYh-0008Mt-2B
	for bug-guix@gnu.org; Sun, 11 Nov 2018 12:30:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLtYg-0007v2-SP
	for bug-guix@gnu.org; Sun, 11 Nov 2018 12:30:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33300.B33300.154195734430352@debbugs.gnu.org>
In-Reply-To: <20181111072334.GF1206@macbook41> (Efraim Flashner's message of
	"Sun, 11 Nov 2018 09:23:34 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 33300@debbugs.gnu.org

Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Fri, Nov 09, 2018 at 12:11:34AM +0100, Bj=C3=B6rn H=C3=B6fling wrote:

[...]

>> One of my review-tasks is this:
>>=20
>> [] Binaries included? If yes, created a snipped?
>>    find . -name "*.rar" -or -name "*.pdf" -or -name "*.bin" -or -name "*=
.pdf" -or -name "*.dsy" -or -name "*.jar" -or -name "*.exe"=20
>
> also "*.so" or "*.a" I assume.
>
> For python we'd want to grep the source files for "Generated by Cython"

Indeed.  The =E2=80=9Crisk=E2=80=9D, if we make the list too long, is that =
we=E2=80=99ll find that
we=E2=80=99re not doing so well in many cases.  We should make sure we can
address all these issues.

>> Should this be a phase of the build system? Or just a linter, that was
>> my first idea?
>
> I'd go with a phase

Same here.  It=E2=80=99d be inconvenient to implement in =E2=80=98guix lint=
=E2=80=99 because
we=E2=80=99d first need to extract the tarball etc.

Thanks,
Ludo=E2=80=99.