From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#36135: installer wifi password prompt
Date: Sat, 08 Jun 2019 21:42:10 +0200
Message-ID: <87zhmr984t.fsf@gnu.org>
References: <20190608151502.5d22d7e8@tachikoma.lepiller.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:41986)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hZhF2-0003xR-BP
 for bug-guix@gnu.org; Sat, 08 Jun 2019 15:43:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hZhF1-0001WF-89
 for bug-guix@gnu.org; Sat, 08 Jun 2019 15:43:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40193)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hZhEz-0001VB-Sj
 for bug-guix@gnu.org; Sat, 08 Jun 2019 15:43:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hZhEz-000652-QB
 for bug-guix@gnu.org; Sat, 08 Jun 2019 15:43:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.36135.B36135.156002294223327@debbugs.gnu.org>
In-Reply-To: <20190608151502.5d22d7e8@tachikoma.lepiller.eu> (Julien
 Lepiller's message of "Sat, 8 Jun 2019 15:15:02 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 36135@debbugs.gnu.org

Hello,

Julien Lepiller <julien@lepiller.eu> skribis:

> * The wifi screen doesn't automatically scan for wifi network, it would
>   be nice if it did it when you first get to that screen.
> * The password prompt is not hidden, it's a simple text prompt.
> * The password prompt was not large enough for my password, so I was
>   unable to connect. I had to use connmanctl from another tty to
>   connect.
> * Even if already connected (outside of the installer), we still have to
>   choose a network. The connected network is marked with a '*' so the
>   code should be able to access that information, I think.

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
> Add an #:INPUT-SHOW-CHECKBOX? to the input page.

[...]

> +                  #:input-show-checkbox? #t))

It=E2=80=99s called #:input-hide-checkbox? AFAICS.

You can double-check that it builds without warnings with:

  guix system vm -v2 gnu/system/install.scm

Please add a =E2=80=9CPartly fixes =E2=80=A6=E2=80=9D line.  This fixes bot=
h the password length
and the password visibility issues since =E2=80=98run-input-page=E2=80=99 w=
ill now use
FLAG-SCROLL.

Thanks!

Ludo=E2=80=99.