From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sGAbJIRl8F4KeAAA0tVLHw (envelope-from ) for ; Mon, 22 Jun 2020 08:02:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YKUHIIRl8F6LdwAAB5/wlQ (envelope-from ) for ; Mon, 22 Jun 2020 08:02:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7B549407C8 for ; Mon, 22 Jun 2020 08:02:11 +0000 (UTC) Received: from localhost ([::1]:36396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnHP7-0003xB-L3 for larch@yhetil.org; Mon, 22 Jun 2020 04:02:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnHP0-0003wk-2P for bug-guix@gnu.org; Mon, 22 Jun 2020 04:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnHOz-00050I-Oe for bug-guix@gnu.org; Mon, 22 Jun 2020 04:02:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnHOz-0005Nw-Mn; Mon, 22 Jun 2020 04:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41908: guix time-machine fails; XXXX is not related to introductory commit of channel 'guix' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 22 Jun 2020 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41908 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Received: via spool by 41908-submit@debbugs.gnu.org id=B41908.159281290120664 (code B ref 41908); Mon, 22 Jun 2020 08:02:01 +0000 Received: (at 41908) by debbugs.gnu.org; 22 Jun 2020 08:01:41 +0000 Received: from localhost ([127.0.0.1]:33239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnHOf-0005NE-IP for submit@debbugs.gnu.org; Mon, 22 Jun 2020 04:01:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnHOc-0005My-5T for 41908@debbugs.gnu.org; Mon, 22 Jun 2020 04:01:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37862) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnHOW-0004ys-Pg; Mon, 22 Jun 2020 04:01:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47028 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jnHOV-00063L-5R; Mon, 22 Jun 2020 04:01:31 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87blli11pi.fsf@gnu.org> <87366qeovy.fsf@gnu.org> <86366qtzdi.fsf@gmail.com> <87tuz6auku.fsf@gnu.org> <86mu4ws8ah.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 22 Jun 2020 10:01:29 +0200 In-Reply-To: <86mu4ws8ah.fsf@gmail.com> (zimoun's message of "Sun, 21 Jun 2020 18:17:10 +0200") Message-ID: <87zh8v7cme.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41908@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: YqLSxUIOK3+H Hi, zimoun skribis: > On Sat, 20 Jun 2020 at 12:40, Ludovic Court=C3=A8s wrote: >> zimoun skribis: > >>> BTW, from a security perspective, it is easy to cheat by removing some >>> commits so the file ~/.cache/guix/authentication/channels/guix should be >>> protected: read-only and only writable by the daemon. >> >> It=E2=80=99s 600 of course. What we could do is ignore it if it=E2=80= =99s not 600 when >> we open it. > > This could help. :-) Done in 41939c374a3ef421d2d4c6453c327a9cd7af4ce5. >> Crucially: we cannot and should not restrict what the user can do for >> the sake of security. Users can pass =E2=80=98--disable-authentication= =E2=80=99, they >> can run binaries taken from the net, whatever; it=E2=80=99s their machin= e. > > Well, I have not thought deeply to an attack, but the point is to > protect the user when they runs "guix pull" alone i.e., they can trust > the server. An attack could be for example an email with an attachment, > click, then boum: tweak ~/.config/guix/channels.scm and > ~/.cache/guix/authentication/channels/guix, then the user runs "guix > pull" which the expectation that everything is checked and > authenticated and in fact no, they is talking to malicious server. I don=E2=80=99t really see how the attachment would modify a local file, but even if that=E2=80=99s a possibility, it=E2=80=99s beyond the scope of Guix= : we cannot prevent users from shooting themselves in the foot. Ludo=E2=80=99.