From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6F6xG1c6r19OSQAA0tVLHw (envelope-from ) for ; Sat, 14 Nov 2020 02:00:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wAKUF1c6r18kDgAAB5/wlQ (envelope-from ) for ; Sat, 14 Nov 2020 02:00:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 933CC94011C for ; Sat, 14 Nov 2020 02:00:54 +0000 (UTC) Received: from localhost ([::1]:42366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdkrz-0006AR-RU for larch@yhetil.org; Fri, 13 Nov 2020 21:00:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdkrC-0006AE-IT for bug-guix@gnu.org; Fri, 13 Nov 2020 21:00:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdkrC-0003pU-80 for bug-guix@gnu.org; Fri, 13 Nov 2020 21:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdkrC-0000Q8-7F for bug-guix@gnu.org; Fri, 13 Nov 2020 21:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44626: tests/build-utils, tests/guix-system: fail when build path contains "~" Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 14 Nov 2020 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44626 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 44626@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16053191431522 (code B ref -1); Sat, 14 Nov 2020 02:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2020 01:59:03 +0000 Received: from localhost ([127.0.0.1]:49581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdkqF-0000OU-3y for submit@debbugs.gnu.org; Fri, 13 Nov 2020 20:59:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:58802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdkqA-0000O1-TA for submit@debbugs.gnu.org; Fri, 13 Nov 2020 20:59:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdkqA-0005tE-Jc for bug-guix@gnu.org; Fri, 13 Nov 2020 20:58:58 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:58340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdkq8-0003l5-5i for bug-guix@gnu.org; Fri, 13 Nov 2020 20:58:58 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id E20601AA41 for ; Fri, 13 Nov 2020 17:58:49 -0800 (PST) From: Vagrant Cascadian Date: Fri, 13 Nov 2020 17:58:46 -0800 Message-ID: <87zh3ksnqh.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/13 20:58:50 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: 5kV0FrEtYHxT --=-=-= Content-Type: text/plain When building from a build path containing a "~", such as: /build/guix-1WL3Dl/guix-1.2.0~rc1/ tests/build-utils.scm and tests/guix-system.sh both fail. I've observed this with v1.2.0rc1, as well as c6e8f40f2ce6082171c18b4aad9877b0ad022563. Building in such a directory revealed two failing tests, which I could reproduce attempting to run the tests directly from a directory that such as /home/vagrant/src/guix~tilde/ using "guix environment --pure guix": make -j2 check RES_OPTIONS=attempts:0 AM_SCM_LOG_DRIVER_FLAGS="--brief=no" TESTS="tests/build-utils.scm tests/guix-system.sh" Running the same tests in /home/vagrant/src/guix-tilde PASSed. (FWIW, The version is renamed in Debian so that release candidates such are treated as older versions than the eventual released version (e.g. 1.2.0rc1 > 1.2.0 > 1.2.0~rc1 for Debian package versions) and it would be best for Debian to be able to use the ~ in the Debian package version) FAIL: tests/build-utils ======================= ... test-name: wrap-script, simple case location: /<>/tests/build-utils.scm:152 source: + (test-equal + "wrap-script, simple case" + (string-append + (format + #f + "#!~a --no-auto-compile\n#!#; Guix wrapper\n#\\-~s\n#\\-~s\n" + (which "guile") + '(begin + (let ((current (getenv "GUIX_FOO"))) + (setenv + "GUIX_FOO" + (if current + (string-append + "/some/path:/some/other/path" + ":" + current) + "/some/path:/some/other/path")))) + '(let ((cl (command-line))) + (apply execl + "/anything/cabbage-bash-1.2.3/bin/sh" + (car cl) + (cons (car cl) (append '("") cl))))) + script-contents) + (call-with-temporary-directory + (lambda (directory) + (let ((script-file-name + (string-append directory "/foo"))) + (call-with-output-file + script-file-name + (lambda (port) (format port script-contents))) + (chmod script-file-name 511) + (wrap-script + script-file-name + `("GUIX_FOO" + prefix + ("/some/path" "/some/other/path"))) + (let ((str (call-with-input-file + script-file-name + get-string-all))) + (with-directory-excursion + directory + (delete-file "foo")) + str))))) FORMAT: INTERNAL ERROR IN FORMAT-ERROR! destination: # format string: "#!/<>/guile --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append \"/some/path:/some/other/path\" \":\" current) \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) (append (quote (\"\")) cl))))\n" format args: () error args: (#f "error in format" () #f) FORMAT: INTERNAL ERROR IN FORMAT-ERROR! destination: # format string: "#!/<>/guile --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append \"/some/path:/some/other/path\" \":\" current) \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) (append (quote (\"\")) cl))))\n" format args: () error args: (#<&wrap-error program: "/tmp/guix-directory.s4eviV/foo" type: misc-error>) expected-value: "#!/<>/guile --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append \"/some/path:/some/other/path\" \":\" current) \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) (append (quote (\"\")) cl))))\n#!/anything/cabbage-bash-1.2.3/bin/sh\n\necho hello world" actual-value: #f actual-error: + (%exception + #<&wrap-error program: "/tmp/guix-directory.s4eviV/foo" type: misc-error>) result: FAIL FAIL: tests/guix-system ======================= + set -e + guix system --version guix system (GNU Guix) 1.2.0rc1 Copyright (C) 2020 the Guix authors License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. + tmpfile=t-guix-system-6249 + errorfile=t-guix-system-error-6249 + tmpdir=/tmp/t-guix-system-6249 + mkdir /tmp/t-guix-system-6249 + trap 'rm -f "$tmpfile" "$errorfile" "$tmpdir"/*; rmdir "$tmpdir"' EXIT + cat + guix system vm t-guix-system-6249 + grep 't-guix-system-6249:2:3:.*missing.* initializers' t-guix-system-error-6249 t-guix-system-6249:2:3: error: (operating-system): missing field initializers (bootloader host-name file-systems timezone) + cat + guix system vm t-guix-system-6249 + grep 't-guix-system-6249:4:1: missing closing paren' t-guix-system-error-6249 t-guix-system-6249:4:1: missing closing parenthesis + cat + guix system build t-guix-system-6249 -n + grep 't-guix-system-6249:3:2: .*module .*openssh.*not found' t-guix-system-error-6249 t-guix-system-6249:3:2: error: module (gnu services openssh) not found + grep 'Try.*use-service-modules ssh' t-guix-system-error-6249 hint: Try adding `(use-service-modules ssh)'. + cat + guix system build t-guix-system-6249 -n + grep 't-guix-system-6249:3:2: .*module .*qemu.*not found' t-guix-system-error-6249 t-guix-system-6249:3:2: error: module (gnu packages qemu) not found + grep 'Try.*use-package-modules virtualization' t-guix-system-error-6249 hint: Try adding `(use-package-modules virtualization)'. + cat + guix system build t-guix-system-6249 -n ++ guile -c '(display (effective-version))' + test 3.0 = 3.0 + grep 't-guix-system-6249:[0-9]\+:[0-9]\+:.*GRUB-config.*[Uu]nbound variable' t-guix-system-error-6249 t-guix-system-6249:9:14: error: GRUB-config: unbound variable + cat + guix system build t-guix-system-6249 -n + grep 't-guix-system-6249:3:[0-9]\+:.*%base-file-system.*invalid field specifier' t-guix-system-error-6249 t-guix-system-6249:3:0: error: %base-file-systems: invalid field specifier + OS_BASE=' (host-name "antelope") (timezone "Europe/Paris") (locale "en_US.UTF-8") (bootloader (bootloader-configuration (bootloader grub-bootloader) (target "/dev/sdX"))) (file-systems (cons (file-system (device (file-system-label "root")) (mount-point "/") (type "ext4")) %base-file-systems)) ' + cat + guix system vm t-guix-system-6249 accepted connection from pid 6412, user vagrant + grep 'service '\''networking'\''.*more than once' t-guix-system-error-6249 guix system: error: service 'networking' provided more than once + cat + guix system build t-guix-system-6249 accepted connection from pid 6433, user vagrant + grep 'service '\''buggy!'\''.*'\''does-not-exist'\''.*not provided' t-guix-system-error-6249 guix system: error: service 'buggy!' requires 'does-not-exist', which is not provided by any service + make_user_config users wheel + cat + guix system build t-guix-system-6249 -n accepted connection from pid 6454, user vagrant guix system: error: invalid character `~' in name `shepherd-file-system--build-guix-1WL3Dl-guix-1.2.0~rc1-test-tmp-store.scm-builder' + rm -f t-guix-system-6249 t-guix-system-error-6249 '/tmp/t-guix-system-6249/*' + rmdir /tmp/t-guix-system-6249 FAIL tests/guix-system.sh (exit status: 1) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX6851gAKCRDcUY/If5cW qlLYAQCsOf6TnUTGUpoj/8Mtd32XG4g4mT7IJz3m9+yWF7fk3AD+NDPqb8zWnreg YvNPW99Qh+QXCtT3lK629F3CJv7X+go= =KeiC -----END PGP SIGNATURE----- --=-=-=--