From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gG2VE15Ds19fQwAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 03:28:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id XvJ8D15Ds1+JEgAA1q6Kng (envelope-from ) for ; Tue, 17 Nov 2020 03:28:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC0D7940222 for ; Tue, 17 Nov 2020 03:28:29 +0000 (UTC) Received: from localhost ([::1]:52894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kerfP-0001ww-4J for larch@yhetil.org; Mon, 16 Nov 2020 22:28:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kerf0-0001tM-2f for bug-guix@gnu.org; Mon, 16 Nov 2020 22:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kerez-00087A-Nn for bug-guix@gnu.org; Mon, 16 Nov 2020 22:28:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kerez-0000aU-JF for bug-guix@gnu.org; Mon, 16 Nov 2020 22:28:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44626: tests/build-utils, tests/guix-system: fail when build path contains "~" Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 17 Nov 2020 03:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44626 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44626-submit@debbugs.gnu.org id=B44626.16055836272195 (code B ref 44626); Tue, 17 Nov 2020 03:28:01 +0000 Received: (at 44626) by debbugs.gnu.org; 17 Nov 2020 03:27:07 +0000 Received: from localhost ([127.0.0.1]:57985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kere7-0000ZL-BR for submit@debbugs.gnu.org; Mon, 16 Nov 2020 22:27:07 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:48266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kere3-0000Yp-Dv for 44626@debbugs.gnu.org; Mon, 16 Nov 2020 22:27:06 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 2C8A11AA41; Mon, 16 Nov 2020 19:26:57 -0800 (PST) From: Vagrant Cascadian In-Reply-To: <87pn4dy0od.fsf@gnu.org> References: <87zh3ksnqh.fsf@yucca> <87pn4dy0od.fsf@gnu.org> Date: Mon, 16 Nov 2020 19:26:53 -0800 Message-ID: <87zh3gr7cy.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44626@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: v6Nkie8fXDcJ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2020-11-16, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: > >> When building from a build path containing a "~", such as: >> >> /build/guix-1WL3Dl/guix-1.2.0~rc1/ >> >> tests/build-utils.scm and tests/guix-system.sh both fail. > > [...] > >> FAIL: tests/build-utils >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> ... >> test-name: wrap-script, simple case >> location: /<>/tests/build-utils.scm:152 >> source: >> + (test-equal >> + "wrap-script, simple case" > > [=E2=80=A6] > >> + make_user_config users wheel >> + cat >> + guix system build t-guix-system-6249 -n >> accepted connection from pid 6454, user vagrant >> guix system: error: invalid character `~' in name `shepherd-file-system-= -build-guix-1WL3Dl-guix-1.2.0~rc1-test-tmp-store.scm-builder' > > I believe both are fixed by 977eb5d023cfdf8e336f1896480eea9cef5c04e9. Thanks for the quick fix! That seems to fix tests/guix-system.sh... Though may introduce a different issue in tests/build-utils.log: ... test-name: wrap-script, simple case location: /build/guix-41NMGX/guix-1.2.0~rc1/tests/build-utils.scm:152 source: + (test-equal + "wrap-script, simple case" + (string-append + (format + #f + "#!~a --no-auto-compile\n#!#; Guix wrapper\n#\\-~s\n#\\-~s\n" + (which "guile") + '(begin + (let ((current (getenv "GUIX_FOO"))) + (setenv + "GUIX_FOO" + (if current + (string-append + "/some/path:/some/other/path" + ":" + current) + "/some/path:/some/other/path")))) + '(let ((cl (command-line))) + (apply execl + "/anything/cabbage-bash-1.2.3/bin/sh" + (car cl) + (cons (car cl) (append '("") cl))))) + script-contents) + (call-with-temporary-directory + (lambda (directory) + (let ((script-file-name + (string-append directory "/foo"))) + (call-with-output-file + script-file-name + (lambda (port) (display script-contents port))) + (chmod script-file-name 511) + (wrap-script + script-file-name + `("GUIX_FOO" + prefix + ("/some/path" "/some/other/path"))) + (let ((str (call-with-input-file + script-file-name + get-string-all))) + (with-directory-excursion + directory + (delete-file "foo")) + str))))) FORMAT: INTERNAL ERROR IN FORMAT-ERROR! destination: # format string: "#!/build/guix-41NMGX/guix-1.2.0~rc1/guile --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append \"/some/path:/some/other/path\" \":\" current) \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) (append (quote (\"\")) cl))))\n" format args: () error args: (#f "error in format" () #f) FORMAT: INTERNAL ERROR IN FORMAT-ERROR! destination: # format string: "#!/build/guix-41NMGX/guix-1.2.0~rc1/guile --no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append \"/some/path:/some/other/path\" \":\" current) \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) (append (quote (\"\")) cl))))\n" format args: () error args: (#<&wrap-error program: "/tmp/guix-directory.YrSRbV/foo" type: misc-error>) expected-value: "#!/build/guix-41NMGX/guix-1.2.0~rc1/guile =2D-no-auto-compile\n#!#; Guix wrapper\n#\\-(begin (let ((current (getenv \"GUIX_FOO\"))) (setenv \"GUIX_FOO\" (if current (string-append \"/some/path:/some/other/path\" \":\" current) \"/some/path:/some/other/path\"))))\n#\\-(let ((cl (command-line))) (apply execl \"/anything/cabbage-bash-1.2.3/bin/sh\" (car cl) (cons (car cl) (append (quote (\"\")) cl))))\n#!/anything/cabbage-bash-1.2.3/bin/sh\n\necho hello world" actual-value: #f actual-error: + (%exception + #<&wrap-error program: "/tmp/guix-directory.YrSRbV/foo" type: misc-error>) result: FAIL test-name: wrap-script, with encoding declaration ... result: PASS test-name: wrap-script, raises condition ... result: PASS FORMAT: error with call: (format # "#!/build/guix-41NMGX/guix-1.2.0~r<=3D=3D=3Dc1/guile --no-auto-compile #!#; Guix wrapper #\-(begin (let ((current (getenv "GUIX_FOO"))) (setenv "GUIX_FOO" (if current (string-append "/some/path:/some/other/path" ":" current) "/some/path:/some/other/path")))) #\-(let ((cl (command-line))) (apply execl "/anything/cabbage-bash-1.2.3/bin/sh" (car cl) (cons (car cl) (append (quote ("")) cl)))) " =3D=3D=3D>) missing argument(s) wrap-script: /tmp/guix-directory.YrSRbV/foo: error: misc-error (#f "error in format" () #f) Not sure what test or where in the code that last error is coming from... Because I've added so many network-reachable/test-skip patches, it is *possible* that it is something I've broken... Thanks! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX7NC/QAKCRDcUY/If5cW qnjRAP47ILbZMkZcXzet9ZArCHhzqvZMrvuOY660WzS3dYBbiAD7BOFRwiziuNIa RLH6yeFFEbIJQQ27Dt3nhCOChzR8lgw= =irep -----END PGP SIGNATURE----- --=-=-=--