unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 45448@debbugs.gnu.org
Subject: bug#45448: Emacs can't load org mode after last update
Date: Mon, 28 Dec 2020 16:34:08 +0000	[thread overview]
Message-ID: <87zh1xyjnj.fsf@gmx.com> (raw)
In-Reply-To: <87a6tyc6ph.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]


Nicolas Goaziou writes:

> Hello,
>
> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> In the meantime, we can either revert the update or just fix it
>> downstream temporarily. The following patch works for me for example:
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index eaa0fc8d2a..e65666a6ac 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -10296,6 +10296,11 @@ passive voice.")
>>      (arguments
>>       `(#:phases
>>         (modify-phases %standard-phases
>> +         (add-after 'unpack 'fix-org-version
>> +           (lambda _
>> +             (substitute* "org-version.el"
>> +               (("org-release \"\"") (string-append "org-release \"" ,version "\"")))
>> +             #t))
>>           (add-after 'install 'install-documentation
>>             (lambda* (#:key outputs #:allow-other-keys)
>>               (let* ((share (string-append (assoc-ref outputs "out") "/share"))
>>
>> I'm more tempted to add this little fix rather than revert the update,
>> given we'd also have to revert org-contrib.
>
> Indeed. LGTM. Thank you!

Great! I've just pushed with commit
cd11f6a2bd703f0859aec05c0873186b734d6d74, adding a comment to remove
this phase when the issue is resolved upstream.

Thanks!
Pierre

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

  reply	other threads:[~2020-12-28 16:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26 17:42 bug#45448: Emacs can't load org mode after last update Marinus Savoritias
2020-12-27  9:19 ` Michael Rohleder
2020-12-27 11:03 ` Pierre Langlois
2020-12-27 13:07   ` Pierre Langlois
2020-12-28 13:21     ` Pierre Langlois
2020-12-28 15:04       ` Nicolas Goaziou
2020-12-28 16:34         ` Pierre Langlois [this message]
2021-01-15 21:53           ` Michael Rohleder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh1xyjnj.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=45448@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).