unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 46402@debbugs.gnu.org
Subject: bug#46402: Cuirass rebuilds the same packae multiple times
Date: Wed, 10 Feb 2021 11:46:51 +0100	[thread overview]
Message-ID: <87zh0c8ajo.fsf@gnu.org> (raw)
In-Reply-To: <87lfbxs0w9.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 09 Feb 2021 16:42:46 +0100")

Hi,

Mathieu Othacehe <othacehe@gnu.org> skribis:

>> here is an example: https://ci.guix.gnu.org/build/287478/details and
>> https://ci.guix.gnu.org/build/287476/details are being built at the
>> same time, and the logs currently show they are both running the test
>> phase of the php package.
>
> Thanks for the report. This problem has been briefly discussed
> yesterday. It has been introduced by the new remote building mechanism
> in Cuirass. Hydra solves it by breaking each build into buildsteps
> corresponding to the derivation inputs.
>
> The buildsteps are then submitted to the workers in a logical order. I
> proposed to introduce a similar mechanism in Cuirass but Ludo expressed
> doubts. Ludo do you think this problem could be solved otherwise?

I’m not sure exactly but I can share my feelings.  :-)

Seems to me that ‘BuildSteps’ is an orthogonal concern that has little
to do with Cuirass’ job and with its data model.  In Hydra I saw that as
a (necessary) kludge.

I like the way the Coordinator does it, and AIUI it’s pretty much the
same as what the daemon is doing: submit build requests in topological
order, such that when a derivation build is submitted, its prerequisites
are known to be built already.

I suppose what makes it more difficult here is that we have this extra
“job” abstraction on top of derivations; everything in Cuirass revolves
around jobs, which leads to this impedance mismatch.

If Cuirass would instead delegate derivation build requests to a
Coordinator/daemon-like thing, it wouldn’t have to worry about those
details.  That would better separate concerns.

This is quite a hand-wavy reply but I hope it’s useful!

Thanks,
Ludo’.




  reply	other threads:[~2021-02-10 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 13:19 bug#46402: Cuirass rebuilds the same packae multiple times Julien Lepiller
2021-02-09 15:42 ` Mathieu Othacehe
2021-02-10 10:46   ` Ludovic Courtès [this message]
2021-02-10 11:24     ` Mathieu Othacehe
2021-02-17 14:22       ` Ludovic Courtès
2021-05-28 12:51 ` Mathieu Othacehe
2021-05-28 18:40   ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh0c8ajo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=46402@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).