unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 47964@debbugs.gnu.org, bone.baboon@disroot.org
Subject: bug#47964: webkitgtk-2.32.0 build fails
Date: Mon, 26 Apr 2021 18:44:10 +0200	[thread overview]
Message-ID: <87zgxlro6d.fsf@nckx> (raw)
In-Reply-To: <YIblbM2t3WJzhIhK@jasmine.lan>


[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]

Leo,

Leo Famulari 写道:
> It's unusual that a program requires multithreaded compilation, 
> but I
> wonder if we can add a property to the package definition to 
> require at
> least 2 threads when building.

That's a great idea, although I'm not keen on .*using properties 
for it.

How about this?

Kind regards,

T G-R


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-webkitgtk-Always-use-at-least-2-make-jobs.patch --]
[-- Type: text/x-patch, Size: 1180 bytes --]

From a9ef0c78c6aa60ab49f6fcf4fc6b43afdb6f0183 Mon Sep 17 00:00:00 2001
From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 26 Apr 2021 18:39:58 +0200
Subject: [PATCH] gnu: webkitgtk: Always use at least 2 make jobs.

Fixes <http://issues.guix.gnu.org/47964>.

* gnu/packages/webkit.scm (webkitgtk)[arguments]: Use at least -j2.
---
 gnu/packages/webkit.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index 083c8ccb08..74ffe92b84 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -260,6 +260,9 @@ acceleration in mind, leveraging common 3D graphics APIs for best performance.")
                           ;; now, we explicitly disable it to prevent an error
                           ;; at configuration time.
                           "-DUSE_GSTREAMER_GL=OFF")
+       #:make-flags
+       ;; Never build with unsupported -j1: https://issues.guix.gnu.org/47964#5
+       (list "-j" (number->string (max 2 (parallel-job-count))))
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'configure-bubblewrap-store-directory
-- 
2.31.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-04-26 16:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  4:46 bug#47964: webkitgtk-2.32.0 build fails Bone Baboon via Bug reports for GNU Guix
2021-04-23 18:41 ` Leo Famulari
2021-04-23 20:11   ` Bone Baboon via Bug reports for GNU Guix
2021-04-23 20:25     ` Leo Famulari
2021-04-23 22:04       ` Leo Famulari
2021-04-26 13:58         ` Bone Baboon via Bug reports for GNU Guix
2021-04-26 16:08           ` Leo Famulari
2021-04-26 16:44             ` Tobias Geerinckx-Rice via Bug reports for GNU Guix [this message]
2021-04-26 17:19               ` Leo Famulari
2021-04-27 12:48                 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-04-26 18:25             ` Bone Baboon via Bug reports for GNU Guix
2021-04-23 21:37 ` Bone Baboon via Bug reports for GNU Guix
2021-04-26 14:52 ` bug#47964: Closing bug#47964 Bone Baboon via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgxlro6d.fsf@nckx \
    --to=bug-guix@gnu.org \
    --cc=47964@debbugs.gnu.org \
    --cc=bone.baboon@disroot.org \
    --cc=leo@famulari.name \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).