From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yOViA7WRkWHkewEAgWs5BA (envelope-from ) for ; Sun, 14 Nov 2021 23:46:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oM2iOrSRkWHcMQAAB5/wlQ (envelope-from ) for ; Sun, 14 Nov 2021 22:46:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E22455A81 for ; Sun, 14 Nov 2021 23:46:11 +0100 (CET) Received: from localhost ([::1]:58004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmOGI-0002CR-Qa for larch@yhetil.org; Sun, 14 Nov 2021 17:46:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmOG9-0002CB-UZ for bug-guix@gnu.org; Sun, 14 Nov 2021 17:46:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmOG9-0006sJ-Lw for bug-guix@gnu.org; Sun, 14 Nov 2021 17:46:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmOG9-0004US-KI for bug-guix@gnu.org; Sun, 14 Nov 2021 17:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51693: [patch] Add Java 17 Resent-From: "Dr. Arne Babenhauserheide" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 14 Nov 2021 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51693 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Julien Lepiller Received: via spool by 51693-submit@debbugs.gnu.org id=B51693.163692993317210 (code B ref 51693); Sun, 14 Nov 2021 22:46:01 +0000 Received: (at 51693) by debbugs.gnu.org; 14 Nov 2021 22:45:33 +0000 Received: from localhost ([127.0.0.1]:51960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmOFa-0004TN-5g for submit@debbugs.gnu.org; Sun, 14 Nov 2021 17:45:33 -0500 Received: from mout.web.de ([217.72.192.78]:36293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmOFX-0004TA-Cy for 51693@debbugs.gnu.org; Sun, 14 Nov 2021 17:45:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1636929914; bh=KCWD8bJbs+smcVoje9yUgdvTnr0WR2RqIag8z+rG2dM=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=ho3VNDjrIBrNhR+OxKQMH6eCrtckQZsPl8SBfKrtup1WOlJI2g7pyziHR7k02J+Cn jWoomQ4Kmg9cihpxswZU5colwnNhRVBCAMLp9NwmOWCTkNzm57mtIZWT0yCuzsRm6d dNxmqWNZnRwC43M/JXM/K+9x7FLM5vhyJGu0NVyE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from fluss ([84.149.85.224]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mho0A-1m8ddx3Vk8-00dtnY; Sun, 14 Nov 2021 23:45:13 +0100 References: <87y25yxu7y.fsf@web.de> <20211114165407.5223d22f@tachikoma.lepiller.eu> User-agent: mu4e 1.6.9; emacs 27.2 From: "Dr. Arne Babenhauserheide" Date: Sun, 14 Nov 2021 21:59:44 +0100 In-reply-to: <20211114165407.5223d22f@tachikoma.lepiller.eu> Message-ID: <87zgq61hmw.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:aEDMLSAGtT0eFqBR3Mvta1ahGJlw0t4467QNx5qRH0P/8jyThMq kyGcXCrkqAEo2Wmt7LlMFNce9uOTj4RJjuAp/wBNfbzHz+RzpfOabQ1o5wCdLg17tKLSThY fZOmOlG1JPaHu6ii32HCpL9o+ySh4mxiQGfYifq/6Yf0yG4j2fa8td9nxMETU6td/R6Swge IfhuE2IiVCOxHRJsCbEKQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Dqfnise4GF8=:C4xuhHwi5IQYS4+jqQPgsL XgAaIuT3SMppvgVk9DnIsXmPi1D/GqKqmmiOTRfj4KPfLiIv7pZPBhtEQqTpDPBYJ2sxlLe5G HP5yXrV11lkyXciDCF1xpkSOaWGW9gW6MJNI3GdU02Em9zVwW4gESV3pxF5SYvNCRdZwvHMDB 3STUaz6xjB3a3MtwqMk1v6gJjefWcMfV8ERbh98QN7OPk/s+pmHzOwNPQjYfEJROjHkMfq4P4 eDQtnCexvyODDQKts5VI2All9BDS8Q9UhCwC1xwQe6UZ+xGD6DgqZ2q4EoPTgBj6Knsys6vaK bMK6yeJyU+aR7V9YyXG6gP/pYXThK3/928C/5/SrQbAK7v5sgqMdNaGwKs787tIuZ/Cy6zyKC 0tAjXGD8p2rsXsPaZBECZFuEOvlJNGEsnWISMOGgSVm0bNbshEpMl/XQfAcw78Ey9N3Qj7NSh drhWi1L9D4ZGFw42lAIXHI9oJWQLvGwUriCR2ZNM8DnoXipbJxJSH4g+CI1C/N8RNHj3UKGjD dnjNLvcx8JLHnlFabmx4pKPRwAWMpOZzUm977FUEArh1EY9qCA+EZMOEWU6ax3c0rxkUQ7YdL jQ4Ti1WYfYR6Kdzg/cnQTNjRI0JzPjee+l0jU3aaYHilJuMN8OMWk9rcp2N0M7D89GTqke3SW YdrTDEhPNrMH1EgFAbRMzVeg8VBp1DDZl3vfQSfoAUhwPutIw5/V38MTy5krKfF5EQaiBbDjn fZBBN4u8mkBQau4ImJTAkbzwwH++qPDx0qoYmyihaUeXdrNUsDIB/vB+xUwnO7xVbeDnCnt3r RNzFi+LNmBQ+TA35A31F1vnSE1h/zmJi2tMHk/2MUuWR10lXKfsU/xkqOL2u8wOz14SmlrvZO 1j2sd+PEWpp8kTd1Um9M6ElyJ8dXfjeosFTJmpTPSzJIjzZ4sk8D5ENennbZ2IlVBXlhY19Z0 XilnEViI53sLqgiUxmXP4qpd/ybKmPpJJ7nO+o+XSUfD03yqUsx4kxVy/5L0cdkRgkS6EVz04 wvcaxEoG1WTBYexhKeIkhx1gqRQj9ETM0ZrTZl6XnrkIXwspUyosudVRdeyUFBXYSNbJEUBN+ qIkdQHY2m8INIQ= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51693@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636929972; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qtW871Q/XEZKetO2eji7Zq/2kbLQmLAt64XECXul+cA=; b=WgyQp8rig4qq60qDIfvwbUV5Y7ol9Iw02y5gDO3kUhl1cFM3FyW65XbI0yiWFvCCK5B9qF PjO5rdtkUBNOwlacGghYMR8U6cFLtfDKEUHz88SVju2fhb1wwRl/diCMAFuKRquwoKKSzg F0+uaGr4h6n3QGg59i5swTOuxIV2v43y23PIAQ/+JA3WDtCkwYGr7+g7X6P1dIQEZcKjkR 8Sd3QbUN12AOu1vQ3dh9vNEI+7wcggk0lAJSzv5aR11YW6gOMSuBhVx8juPwoHUelchlcd BHZEJ4Y5Fdp3NGWphj/dpUG3oJyw2Vb4+UyjYVVlZ+3SoEooxv84AdOr0K6fWA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636929972; a=rsa-sha256; cv=none; b=TPM92Z2CcXe2FtT9pPQumncsiScQLq6OVeAF+FqyCIuQfR2M1LI6jmOpFTbPHWvHMwls17 RyvfzgsBQPaEUawovYYLebbaYby/C1L9oKIIFyUC0HM65BRamEtjyMx1PUJTX2F9Id9Go0 JbfLnlqiLVPN7U++gH9gfVDviuMad3kztk3YLGgcmAMVnZAQwSGTWl4h1KatnmfhbIflwW Nv8EfVmbYUz6AXEh9EbA9al43sFpEa1Ii3ytgUPb9dbbWKnRXRKsUTBe7Wmrhez+te7tK3 a1Eg5La3UqZEsNjJguM2W2UZ7EmLWSSJ9gLL4aZE+ncUaMHWOYeZYvBWgIYluA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=web.de header.s=dbaedf251592 header.b=ho3VNDjr; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=web.de header.s=dbaedf251592 header.b=ho3VNDjr; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E22455A81 X-Spam-Score: -3.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: BiXzVaWYfm7H --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Lepiller writes: > Le Mon, 08 Nov 2021 21:32:16 +0100, > "Dr. Arne Babenhauserheide" a =C3=A9crit : > >> the attached patch adds openjdk@17 >>=20 >> Take care with updating packages depending on this, because the >> changes to the module system can cause runtime failures. > sorry for the delay. No problems =E2=80=94 thank you for checking my patch! > I tried your patch, but the build fails for me > because it goes "out of file descriptors" and "unix resources". Does it > work for you? It works for me, yes. ./pre-inst-env guix environment --ad-hoc openjdk@17:jdk -- java -version =E2=80=A6 openjdk version "17.0.1" 2021-10-19 OpenJDK Runtime Environment (build 17.0.1+0-adhoc..source) OpenJDK 64-Bit Server VM (build 17.0.1+0-adhoc..source, mixed mode, sharing) > I tried with various levels of parallelism, but it did not > change anything. > > also about your patch, could you replace (invoke "chmod" "u+w" file) > with a call to make-writable? Do you mean `make-file-writable` ? I switched to that now. > It's available by default in the build > environment, it comes from (guix build utils). I wonder also why you > inherit arguments from openjdk15 instead of openjdk16? That was a mistake =E2=80=94 thank you! I attached a new patch. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-openjdk17-add-Java-17.0.1.patch Content-Transfer-Encoding: quoted-printable From=205d9d3e96163798fe9b8146f134e47311b4e0ac77 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Mon, 8 Nov 2021 21:21:41 +0100 Subject: [PATCH] gnu: openjdk17: add Java 17.0.1. * gnu/packages/java.scm (openjdk17): 17.0.1 Thanks to Julien Lepiller for feedback! =2D-- gnu/packages/java.scm | 48 +++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index da72dbb38c..b62d730fc4 100644 =2D-- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2566,6 +2566,42 @@ (define-public openjdk16 ("zip" ,zip))) (arguments (substitute-keyword-arguments (package-arguments openjdk15) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'unpack 'make-templates-writable + (lambda _ + ;; The build system copies a few .template files from the + ;; source directory into the build directory and then modif= ies + ;; them in-place. So these files have to be writable. + (for-each make-file-writable + (find-files "src/java.base/share/classes/jdk/internal/misc= /" + "\\.template$")) + #t)))))) + (home-page "https://openjdk.java.net/projects/jdk/16"))) + +(define-public openjdk17 + (package + (inherit openjdk16) + (name "openjdk") + (version "17.0.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/openjdk/jdk17u") + (commit (string-append "jdk-" version "-ga")))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1l1jgbz8q7zq66npfg88r0l5xga427vrz35iys09j44b6qllrldd")))) + (native-inputs + `(("autoconf" ,autoconf) + ("openjdk16:jdk" ,openjdk16 "jdk") + ("pkg-config" ,pkg-config) + ("unzip" ,unzip) + ("which" ,which) + ("zip" ,zip))) + (arguments + (substitute-keyword-arguments (package-arguments openjdk16) ((#:phases phases) `(modify-phases ,phases (add-after 'unpack 'make-templates-writable @@ -2578,8 +2614,16 @@ (define-public openjdk16 (invoke "chmod" "u+w" file)) (find-files "src/java.base/share/classes/jdk/internal/misc= /" "\\.template$")) =2D #t)))))) =2D (home-page "https://openjdk.java.net/projects/jdk/16"))) + #t)) + (replace 'fix-java-shebangs + (lambda _ + ;; This file was "fixed" by patch-source-shebangs, but it r= equires + ;; this exact first line. + (substitute* "make/data/blockedcertsconverter/blocked.certs= .pem" + (("^#!.*") "#! java BlockedCertsConverter SHA-256\n")) + #t)) + )))) + (home-page "https://openjdk.java.net/projects/jdk/17"))) =20 (define-public icedtea icedtea-8) =20 =2D-=20 2.33.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Liebe Gr=C3=BC=C3=9Fe, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmGRkXgQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD69YLD/4n1AaCrvPCFTAL7/gztCzRpukzSFXm3gNH lxRXKonwrD+0LM7CbrWfoYZEIfLaHWXGZd6Q9WX/o3x290pP1WZzxw+kAXCBo/Cj Kac7786Fh8NNNPuHVwcSq13cgEEjQrMLMg+fMTgPC1zWVhXUZLJkkvG/IZ9GrGLB aq/INIlnhbay0HHLqXOKIvx5v9qIgJ/Hj/pY54VxUHmGgmbh9lrKb7yjo2QPiENi yS3GKhHK6q18B87y/95Zx9DxJOFXVak+LX02w8Co97P39JFtGydcPkVhW6zghTD0 Dr/TYuoNh8kFjSRmrZ4jpXvZerCcPEzlsTD+Qk9MAyRGBpZIHA09sAyzivOsNZEJ Gcbe35gVpecCWbUEctak3aU6eRxLK4xD/MyrGEVIWo5e00d7qnnAoMyxmp9z+qnP mSG1x1PFonV6xnryS57BstGZhaM4WoxjpjYXMlzYsh8YOhrdHHP0G0t0g25kVOu6 adQar+GcTjuV4lzGJws/js5vSVehRfcMGaZ9XeutSpUKLyHTlRKLG3GI7oL1muJ8 ChOkdUt0DHdBkcgLxw8horyiA8C2gRTgHBsXU5rZEPf34g6MfbeQl2jftmk901JT 7PaPxkQ6Z38fBzikOHIsrdjovhL+iFFEJntsCDArJtctBwfagn9xEOSd/Kq4UhI7 dCnG6qh9u4jEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmGRkXgQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSL8vA/9iqp2tufqybjATXSF1dOVMvfci FL/Z5FWsKJdBA26FcA3hiVB7/UQL5Rw6/tGNaF2EPw5sR5vAA6o0mkmRt/Xsqr2y 0lbiNyGU6dCN1RLSVRKBTihSuvhYbv2Q0doSV9Lpj5l3ZyQXRT9e7JyhiTbHI6ac 7SNWqZ3+j7UxyYflXw== =wvYA -----END PGP SIGNATURE----- --==-=-=--