unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file
@ 2021-11-17  9:30 Andrew Tropin
  2021-12-19  8:45 ` Xinglu Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Tropin @ 2021-11-17  9:30 UTC (permalink / raw)
  To: 51918; +Cc: Xinglu Chen

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

Test in guix-home.sh looks correct, but it fails:
https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98

Seems something changed in home-bash-service-type, for some reason it
adds the serialized content of aliases field and guix-bashrc variable
after the content of bashrc field.

Original implementation works as expected and adds the content of bashrc
to the end of ~/.bashrc.

--8<---------------cut here---------------start------------->8---
(list
 ((@ (gnu services) service)
  (@ (gnu home-services shells) home-bash-service-type)
  ((@ (gnu home-services shells) home-bash-configuration)
   (guix-defaults? #t)
   (bashrc (list "echo hi"))))
 ((@ (gnu services) simple-service)
  'test-bash
  (@ (gnu home-services shells) home-bash-service-type)
  ((@ (gnu home-services shells) home-bash-extension)
   (bashrc (list "echo very hi")))))
--8<---------------cut here---------------end--------------->8---

https://git.sr.ht/~abcdw/rde/tree/master/item/gnu/home-services/shells.scm

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file
  2021-11-17  9:30 bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file Andrew Tropin
@ 2021-12-19  8:45 ` Xinglu Chen
  2021-12-30  8:26   ` Andrew Tropin
  0 siblings, 1 reply; 3+ messages in thread
From: Xinglu Chen @ 2021-12-19  8:45 UTC (permalink / raw)
  To: Andrew Tropin, 51918

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi,

On Wed, Nov 17 2021, Andrew Tropin wrote:

> Test in guix-home.sh looks correct, but it fails:
> https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98
>
> Seems something changed in home-bash-service-type, for some reason it
> adds the serialized content of aliases field and guix-bashrc variable
> after the content of bashrc field.

This was changed in commit 2f665d4309053d5a9fe25bc93ee78d55dbc30cb7
after discussing it with Liliana[1].  I didn’t really have a strong
opinion on the order of the things; do you think that it should be changed?

[1]: <https://yhetil.org/guix/87k0hs57uu.fsf@disroot.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file
  2021-12-19  8:45 ` Xinglu Chen
@ 2021-12-30  8:26   ` Andrew Tropin
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Tropin @ 2021-12-30  8:26 UTC (permalink / raw)
  To: Xinglu Chen, 51918

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

On 2021-12-19 09:45, Xinglu Chen wrote:

> Hi,
>
> On Wed, Nov 17 2021, Andrew Tropin wrote:
>
>> Test in guix-home.sh looks correct, but it fails:
>> https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98
>>
>> Seems something changed in home-bash-service-type, for some reason it
>> adds the serialized content of aliases field and guix-bashrc variable
>> after the content of bashrc field.
>
> This was changed in commit 2f665d4309053d5a9fe25bc93ee78d55dbc30cb7
> after discussing it with Liliana[1].  I didn’t really have a strong
> opinion on the order of the things; do you think that it should be changed?
>
> [1]: <https://yhetil.org/guix/87k0hs57uu.fsf@disroot.org/>

Seems Ludovic fixed it in c322d97832081e6e1913c6311616030d1fad4ee2, I
just had a slightly outdated local repository, when I was reporting this
bug, everything is ok now)

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-30  8:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17  9:30 bug#51918: home-bash-service-type adds the defaults and aliases to the end of the file Andrew Tropin
2021-12-19  8:45 ` Xinglu Chen
2021-12-30  8:26   ` Andrew Tropin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).