From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: h.goebel@crazy-compilers.com,
Eelco Dolstra <eelco.dolstra@logicblox.com>,
25018-done@debbugs.gnu.org
Subject: bug#25018: GC incorrectly removes the temporary root file of the calling process
Date: Mon, 10 Oct 2022 10:01:01 +0200 [thread overview]
Message-ID: <87zge43y6a.fsf@gnu.org> (raw)
In-Reply-To: <87pmf34afr.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 07 Oct 2022 16:59:20 -0400")
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> I'm not Eelco, but your change LGTM. Note that the upstream version
> still uses the original code [0].
Right.
> I've installed the change, tested that it had the expected result:
>
> reading temporary root file `/var/guix/temproots/8386'
> waiting for read lock on `/var/guix/temproots/8386'
> got temporary root `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo'
> considering whether to delete `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo'
> | cannot delete `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo' because it's a root
> | cannot delete `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo' because it's still reachable
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> ERROR:
> 1. &store-protocol-error:
> message: "cannot delete path `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo' since it is still alive"
> status: 1
>
> and pushed!
Thank you! (Your bug triage work is much appreciated!) We could turn
the example here in a unit test; the only downside is that running the
GC in a test is expensive.
Ludo’.
next prev parent reply other threads:[~2022-10-10 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 14:07 bug#25018: GC incorrectly removes the temporary root file of the calling process Ludovic Courtès
2022-10-07 20:59 ` Maxim Cournoyer
2022-10-10 8:01 ` Ludovic Courtès [this message]
2022-10-10 10:29 ` Maxime Devos
2022-10-10 14:53 ` Ludovic Courtès
2022-10-14 20:30 ` Ludovic Courtès
2022-10-17 1:25 ` Maxim Cournoyer
2022-10-17 8:51 ` Ludovic Courtès
2022-10-18 15:33 ` Maxim Cournoyer
2022-10-10 17:24 ` bug#25018: Broken test suite Ryan Sundberg via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zge43y6a.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=25018-done@debbugs.gnu.org \
--cc=eelco.dolstra@logicblox.com \
--cc=h.goebel@crazy-compilers.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).