unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#58734: installer: backtrace page in final step
@ 2022-10-23  9:39 Mathieu Othacehe
  2022-10-23 13:38 ` Mathieu Othacehe
  0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Othacehe @ 2022-10-23  9:39 UTC (permalink / raw)
  To: 58734


Hello,

When an error occurs in the pseudo terminal displaying the "guix system
init" command output, the backtrace is not displayed correctly and the
keyboard cannot be used (arrows, tab, enter keys) to scroll down the
backtrace or dump it.

It can easily be reproduced by introducing an error in the "run-command"
function, this way:

--8<---------------cut here---------------start------------->8---
--- a/gnu/installer/utils.scm
+++ b/gnu/installer/utils.scm
@@ -184,6 +184,7 @@ (define (pause)
       (((port _ ...) _ _)
        (read-line port))))
 
+  (error 'fake)
   (installer-log-line "running command ~s" command)
   (define result (run-external-command-with-line-hooks
                   (list %display-line-hook) command
--8<---------------cut here---------------end--------------->8---

I suspect that we may need to run "newt-init" and "clear-screen" before
displaying the backtrace page.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#58734: installer: backtrace page in final step
  2022-10-23  9:39 bug#58734: installer: backtrace page in final step Mathieu Othacehe
@ 2022-10-23 13:38 ` Mathieu Othacehe
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2022-10-23 13:38 UTC (permalink / raw)
  To: 58734-done


> +  (error 'fake)
>    (installer-log-line "running command ~s" command)
>    (define result (run-external-command-with-line-hooks
>                    (list %display-line-hook) command

Fixed with bf5e78d59fcb188d0bce02d93c93d06069178837.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-24  2:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-23  9:39 bug#58734: installer: backtrace page in final step Mathieu Othacehe
2022-10-23 13:38 ` Mathieu Othacehe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).