From: Simon Tournier <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 66537@debbugs.gnu.org, guix-patches@gnu.org,
Hiep Pham <hiepph9@proton.me>
Subject: bug#66537: [PATCH] doc: Recommend building in ‘guix shell -CPW’.
Date: Tue, 19 Dec 2023 10:30:32 +0100 [thread overview]
Message-ID: <87zfy64k07.fsf@gmail.com> (raw)
In-Reply-To: <87bkb08zim.fsf_-_@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]
Hi,
On Fri, 08 Dec 2023 at 16:50, Simon Tournier <zimon.toutoune@gmail.com> wrote:
>>> @example
>>> -guix shell --pure
>>> +guix shell -CPW
>>> @end example
>>
>> I would not recommend that or adding also the option -N. Else, the
>> development experience can be annoying.
>
> As said, I disagree with this change pushed by
> 01361d46b8e0481ad56665d7a06c276b08f59c6d.
>
> Could you revert? Because as explained by…
>
>> For instance, “make check” will probably fail because some substitutes
>> are missing (see #67532 [1], e.g., tests/derivations.scm).
>
> …the option ’-CPW’ is not a solution. Other said, it would require in
> addition ’-N’.
Ludo’s answer from bug#67532 [1]:
--8<---------------cut here---------------start------------->8---
I had come to forget about that because for the ‘guix’ package
(obviously built in a network-less environment), we “pre-seed” the store
with the 4 or 5 files needed to run the test suite.
So I propose:
[ text/x-patch ]
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 0833b5d32c..0072e5d42d 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -76,13 +76,13 @@ Building from Git
hack on Guix:
@example
-guix shell -D guix -CPW
+guix shell -D guix -CPWN
@end example
or even, from within a Git worktree for Guix:
@example
-guix shell -CPW
+guix shell -CPWN
@end example
If @option{-C} (short for @option{--container}) is not supported on your
[ text/plain ]
(And not going back to ‘--pure’ because as we know it depends too much
of the goodwill of the user’s shell.)
--8<---------------cut here---------------end--------------->8---
Well, IMHO it falls into…
> To me, this recommendation of container is like a bazooka for chasing
> the real bug: about why --pure does not clean all as expected. Or why
> “guile” is found elsewhere?
…a bazooka for killing a fly. For instance, in the two message of the
initial bug report, I do not see the output of the current
recommendation: run “guix shell --check”.
Yes, “guix shell” depends on the goodwill of the user’s shell but
recommending first --pure is an opportunity for improving --check and/or
--pure itself, IMHO.
Considering this reported instance of issue, it is not clear for me that
--check would not have reported the problem. Or why --pure does not
correctly clean all the environment variables? Or why ./configure set
something system wide?
For me, these questions are the bug. And -CPWN is just a temporary
workaround avoiding the bug and not a fix.
Somehow, if the use of “-CPWN” instead of “--pure“ is not an idea that
user has when hitting a failure with “guix shell --pure”, yeah maybe it
could be helpful to recommend it in addition. And not the contrary. :-)
Something like:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: p.patch --]
[-- Type: text/x-diff, Size: 979 bytes --]
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 7337f4bd58..8f66b3642b 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -76,18 +76,19 @@ Building from Git
hack on Guix:
@example
-guix shell -D guix -CPW
+guix shell -D guix --pure
@end example
or even, from within a Git worktree for Guix:
@example
-guix shell -CPW
+guix shell --pure
@end example
-If @option{-C} (short for @option{--container}) is not supported on your
-system, try @command{--pure} instead of @option{-CPW}.
-@xref{Invoking guix shell}, for more information on that command.
+If building Guix fails, please check the environment variables using the
+option @command{--check}. In the last resort, try @option{-CPWN}
+instead of @command{--pure}. @xref{Invoking guix shell}, for more
+information on that command.
If you are unable to use Guix when building Guix from a checkout, the
following are the required packages in addition to those mentioned in the
[-- Attachment #3: Type: text/plain, Size: 421 bytes --]
That’s said, going your road, I would suggest to add option, say
-A/no-long-name doing all (-CPWN) at once.
Cheers,
simon
1: bug#67532: “make check” requires network
Ludovic Courtès <ludo@gnu.org>
Mon, 11 Dec 2023 22:42:30 +0100
id:87sf482z7d.fsf@gnu.org
https://issues.guix.gnu.org/67532
https://issues.guix.gnu.org/msgid/87sf482z7d.fsf@gnu.org
https://yhetil.org/guix/87sf482z7d.fsf@gnu.org
prev parent reply other threads:[~2023-12-19 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 12:49 bug#66537: configure: error: The Guile bindings of GnuTLS are missing Hiep Pham via Bug reports for GNU Guix
2023-10-17 8:59 ` Daniel Meißner via Bug reports for GNU Guix
2023-10-17 10:28 ` Hiep Pham via Bug reports for GNU Guix
2023-11-22 12:05 ` bug#66537: [PATCH] doc: Recommend building in ‘guix shell -CPW’ Ludovic Courtès
2023-11-29 19:33 ` Simon Tournier
2023-12-08 15:50 ` bug#66537: configure: error: The Guile bindings of GnuTLS are missing Simon Tournier
2023-12-19 9:30 ` Simon Tournier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfy64k07.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=66537@debbugs.gnu.org \
--cc=guix-patches@gnu.org \
--cc=hiepph9@proton.me \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).