From: "Suhail Singh" <suhailsingh247@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 72045@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: bug#72045: Emacs graft lookup still fails
Date: Sat, 13 Jul 2024 19:22:46 -0400 [thread overview]
Message-ID: <87zfqkho6x.fsf@gmail.com> (raw)
In-Reply-To: <b4c6ff2fb41f53b3567e8da9e158a44fbea1ec93.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 10 Jul 2024 22:06:13 +0200")
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> with the grafting of Emacs 29.3 to 29.4, we see that Emacs itself is
> still correctly loaded, but Emacs libraries (e.g. dash) aren't.
>
> (comp-el-to-eln-filename (expand-file-name "…/dash.el"))
> => $HOME/.config/emacs/eln-cache/29.4-46e5bcbe/dash-2.19.1/dash.eln
>
> find $(guix build emacs-dash --with-input=…) -name 'dash.eln'
> => $PREFIX/lib/emacs/native-site-lisp/29.3-62809b9a/dash.eln
>
> It seems that we might have to rebuild emacs native-compiled packages
> even if emacs itself is grafted.
I had missed this message, previously.
IIUC, the issue is that replacement packages are grafted post-build.
This means that when emacs-dash is built, its AOT native-compilation
happens with Emacs 29.3. However, at run-time Emacs 29.4 gets grafted
in.
There are at least two possible ways (ignoring feasibility) to resolve
this:
1. When emacs-dash etc. is being built we use Emacs 29.4 for native
compilation.
2. When emacs-dash etc. is being built we use Emacs 29.3 for native
compilation, but ensure that said files are transferred to a location
where Emacs 29.4 is able to find them.
Which do we desire? My belief is that 1 is what we need, and that doing
2 may be inadequate for ensuring that appropriate security fixes are
deployed (consider the case where the bug is in a macro in Emacs core).
If my analysis above is correct, then the question (which I don't know
the answer to) is can 1 be accomplished with grafts?
--
Suhail
next prev parent reply other threads:[~2024-07-13 23:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 20:06 bug#72045: Emacs graft lookup still fails Liliana Marie Prikler
2024-07-13 5:49 ` bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version Liliana Marie Prikler
2024-07-13 5:53 ` bug#72045: [PATCH 2/2] gnu: emacs-minimal: Ungraft Liliana Marie Prikler
2024-07-13 16:14 ` Suhail Singh
2024-07-13 16:59 ` Liliana Marie Prikler
2024-07-13 16:08 ` bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version Suhail Singh
2024-07-13 17:26 ` Liliana Marie Prikler
2024-07-13 17:59 ` Suhail Singh
2024-07-13 23:22 ` Suhail Singh [this message]
2024-07-14 8:50 ` bug#72045: Emacs graft lookup still fails Liliana Marie Prikler
2024-07-14 16:27 ` Suhail Singh
2024-07-14 16:46 ` Liliana Marie Prikler
2024-07-14 16:56 ` Suhail Singh
2024-07-14 16:59 ` Suhail Singh
2024-07-19 7:35 ` bug#72045: [PATCH v2 1/2] gnu: Add system test for Emacs Liliana Marie Prikler
2024-07-19 15:23 ` Suhail Singh
2024-07-19 15:42 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfqkho6x.fsf@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=72045@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).