[PATCH] distro: Add Attr.

[PATCH] distro: Add Attr.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

Hi,

This patch raises the following warnings.

# ./pre-inst-env guix-build -K attr

[...]

stripping binaries in
"/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/lib" with
flags ("--strip-debug")
strip:/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/lib/libattr.la:
File format not recognized
stripping binaries in
"/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/libexec" with
flags ("--strip-debug")
strip:/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/libexec/libattr.la:
File format not recognized
stripping binaries in
"/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/bin" with
flags ("--strip-debug")
@ build-succeeded
/nix/store/q8w9bbzk0m113aqx5yhywax0yc8pnpyn-attr-2.4.46.drv
/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46
/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46

Is it possible to fix them?

Nikita

[-- Attachment #2: 0001-distro-Add-Attr.patch --]
[-- Type: text/x-diff, Size: 3351 bytes --]

From b07af43dabd9739535ad4b116c86dc550d188896 Mon Sep 17 00:00:00 2001
From: Nikita Karetnikov <nikita@karetnikov.org>
Date: Fri, 7 Dec 2012 00:59:30 +0000
Subject: [PATCH] distro: Add Attr.

* distro/packages/attr.scm: New file.
* Makefile.am (MODULES): Add it.
---
 Makefile.am              |    1 +
 distro/packages/attr.scm |   59 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+), 0 deletions(-)
 create mode 100644 distro/packages/attr.scm

diff --git a/Makefile.am b/Makefile.am
index d5072c7..820a7fc 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -43,6 +43,7 @@ MODULES =					\
   guix/snix.scm					\
   guix.scm					\
   distro.scm					\
+  distro/packages/attr.scm			\
   distro/packages/autotools.scm			\
   distro/packages/base.scm			\
   distro/packages/bash.scm			\
diff --git a/distro/packages/attr.scm b/distro/packages/attr.scm
new file mode 100644
index 0000000..a4851b5
--- /dev/null
+++ b/distro/packages/attr.scm
@@ -0,0 +1,59 @@
+;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
+;;; Copyright (C) 2012 Nikita Karetnikov <nikita@karetnikov.org>
+;;; Copyright (C) 2012 Ludovic Courtès <ludo@gnu.org>
+;;;
+;;; This file is part of Guix.
+;;;
+;;; Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (distro packages attr)
+  #:use-module ((distro packages gettext)
+                #:renamer (symbol-prefix-proc 'guix:))
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public attr
+  (package
+    (name "attr")
+    (version "2.4.46")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://savannah/attr/attr-"
+                          version ".src.tar.gz"))
+      (sha256
+       (base32
+        "07qf6kb2zk512az481bbnsk9jycn477xpva1a726n5pzlzf9pmnw"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (alist-replace 'install
+                      (lambda _
+                        (zero? (system* "make"
+                                        "install"
+                                        "install-lib"
+                                        "install-dev")))
+                      (alist-replace 'check
+                                     (lambda _
+                                       (zero? (system* "test/run")))
+                                     %standard-phases))))
+    (inputs `(("gettext" ,guix:gettext)))
+    (home-page
+     "http://savannah.nongnu.org/projects/attr/")
+    (synopsis
+     "Library and tools for manipulating extended attributes")
+    (description
+     "Library and tools for manipulating extended attributes.")
+    (license '("GPLv2+" "LGPLv2.1+"))))
-- 
1.7.5.4

Re: [PATCH] distro: Add Attr.

[Ludovic Courtès]

Hi,

Applied.  I had to add Perl as an input, and a ‘patch-shebang’ line,
because ‘tests/run’ had #!/usr/bin/perl, which fails in chroots.

BTW, it would be great if you could configure your daemon to run in
chroots, so you can catch these “impurities”.  Perhaps the daemon in
‘nix-integration’ will make it slightly easier to setup.

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> strip:/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/libexec/libattr.la:
> File format not recognized
> stripping binaries in
> "/nix/store/zpzl9z209wnrfi4f90rq7k0lzz7q7ixy-attr-2.4.46/bin" with
> flags ("--strip-debug")

[...]

> Is it possible to fix them?

Not really, but they’re harmless: binaries get stripped after
installation, and sometimes non-ELF files are passed to ‘strip’ (see
build/gnu-build-system.scm.)

Thanks!

Ludo’.

Re: [PATCH] distro: Add Attr.

[Nikita Karetnikov]

> BTW, it would be great if you could configure your daemon to run in
> chroots, so you can catch these “impurities”.  Perhaps the daemon in
> ‘nix-integration’ will make it slightly easier to setup.

Could you elaborate?

There are 'config-daemon.ac', 'daemon.am', and 'nix/nix-daemon' with
sources, but I don't know how to create an executable.

Re: [PATCH] distro: Add Attr.

[Ludovic Courtès]

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> There are 'config-daemon.ac', 'daemon.am', and 'nix/nix-daemon' with
> sources, but I don't know how to create an executable.

Run ./bootstrap, which will checkout Nix as a Git submodule, and then
copy the relevant bits in the ‘nix’ sub-directory.

Then run ‘./configure --enable-daemon’, etc.

Ludo’.

Re: [PATCH] distro: Add Attr.

[Nikita Karetnikov]

> Run ./bootstrap, which will checkout Nix as a Git submodule, and then
> copy the relevant bits in the ‘nix’ sub-directory.

> Then run ‘./configure --enable-daemon’, etc.

# make
make: *** No rule to make target `nix/libstore/schema.sql', needed by
`nix/libstore/schema.sql.hh'.  Stop.

Also, how should I use it? It's in the
'remotes/origin/nix-integration' branch and I have to work in the
'master' branch.

Re: [PATCH] distro: Add Attr.

[Ludovic Courtès]

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> # make
> make: *** No rule to make target `nix/libstore/schema.sql', needed by
> `nix/libstore/schema.sql.hh'.  Stop.

Did you run ‘./bootstrap’ or ‘./nix/sync-with-upstream’?  Normally you
should have seen a line like:

  `./libstore/schema.sql' -> `../../nix/./libstore/schema.sql'

> Also, how should I use it? It's in the
> 'remotes/origin/nix-integration' branch and I have to work in the
> 'master' branch.

Yeah, I hope to merge that branch soon.

Ludo’.