From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 22013-done@debbugs.gnu.org
Subject: bug#22013: python2 versions of packages failing as inputs
Date: Sun, 13 Dec 2015 19:16:15 +0100 [thread overview]
Message-ID: <87y4cyuscw.fsf@gnu.org> (raw)
In-Reply-To: <20151126120601.06f5e5bc@debian-netbook> (Efraim Flashner's message of "Thu, 26 Nov 2015 12:06:01 +0200")
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Thu, 26 Nov 2015 09:59:12 +0100
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>> > Efraim Flashner <efraim@flashner.co.il> writes:
>> >
>> >> Guix build python2-cryptography builds fine, guix build python2-oauthlib
>> >> rebuilds python2-cryptography, and fails to build. Python2-cryptography has
>> >> an additional input of python2-ipaddress which doesn't get carried along when
>> >> python2-cryptography is an input and not the final build.
>> >
>> > I think that’s pretty normal. We have the same situation in
>> > ‘python2-openssl’ where we have to explicitly add ‘python2-cryptography’
>> > and remove ‘python-cryptography’.
>>
>> Yes, and this is due to the fact that ‘python2-cryptography’ is not just
>> an automatically-translated package:
>>
>> (define-public python2-cryptography
>> (let ((crypto (package-with-python2 python-cryptography)))
>> (package (inherit crypto)
>> (propagated-inputs
>> `(("python2-ipaddress" ,python2-ipaddress)
>> ,@(package-propagated-inputs crypto))))))
>>
>> If it were simply equal to (package-with-python2 python-cryptography),
>> there would be no need for the manual tweak in ‘python-pyopenssl’.
>>
>> Efraim, could you apply the same strategy as for ‘python2-pyopenssl’ in
>> ‘python2-oauthlib’?
>
> Ok, I understand now. I thought I had to edit python2-cryptography to fix
> python2-oauthlib, now I realize everytime I use python2-cryptography I need
> to make sure it pulls the right one.
AFAICS this was fixed in 0066de6, so I’m closing it.
>> > It would, of course, be nice if package-with-python2 could handle this
>> > automatically.
>>
>> I think we would need a way to register “translation” results.
>> Currently ‘package-with-python2’ internally uses a hash table to memoize
>> conversion results. We could imagine adding something like:
>>
>> (register-python2-variant PY3VARIANT PY2VARIANT)
>>
>> to explicitly add a pair to that hash table.
>>
>> The downside of this approach is that this would break referential
>> transparency.
>>
>> WDYT?
For this more general issue, we should open a different bug.
Thanks,
Ludo’.
prev parent reply other threads:[~2015-12-13 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 18:55 bug#22013: python2 versions of packages failing as inputs Efraim Flashner
2015-11-25 22:00 ` Ricardo Wurmus
2015-11-26 8:59 ` Ludovic Courtès
2015-11-26 10:06 ` Efraim Flashner
2015-12-13 18:16 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4cyuscw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=22013-done@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).