From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#24275: Misnamed directory in GuixSD
Date: Sun, 28 Aug 2016 15:48:25 +0200
Message-ID: <87y43h2edy.fsf@gnu.org>
References: <20160820201100.GA22429@jocasta.intra>
	<20160821231410.GA4548@jasmine> <87bn0lciy1.fsf@gmail.com>
	<CAEwRq=pGz-7MX9j=zZ9Z_RMbgyvVZtDS-DROZ-3OwanfFK_SoQ@mail.gmail.com>
	<20160822180903.GB17367@jasmine>
	<CAEwRq=rhhGh1MpZef30m=Ke6Zo9NB3ARULwuEqF5Jz3DO_sFLA@mail.gmail.com>
	<87twe54wlq.fsf@gnu.org>
	<CAEwRq=r2qeDgqXyB6LaREJFW3=DZzBj_hqcbkoods_FdOB==Aw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1be0SS-00068C-T5
	for bug-guix@gnu.org; Sun, 28 Aug 2016 09:49:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1be0SM-0007nB-B6
	for bug-guix@gnu.org; Sun, 28 Aug 2016 09:49:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1be0SM-0007n4-87
	for bug-guix@gnu.org; Sun, 28 Aug 2016 09:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1be0SM-00043U-3y
	for bug-guix@gnu.org; Sun, 28 Aug 2016 09:49:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.24275.D24275.147239213215567.done@debbugs.gnu.org>
In-Reply-To: <CAEwRq=r2qeDgqXyB6LaREJFW3=DZzBj_hqcbkoods_FdOB==Aw@mail.gmail.com>
	(Vincent Legoll's message of "Sun, 28 Aug 2016 01:49:09 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: Alex Kost <alezost@gmail.com>, 24275-done@debbugs.gnu.org, John Darrington <john@darrington.wattle.id.au>

Hello!

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> On Sun, Aug 28, 2016 at 1:32 AM, Ludovic Court=C3=A8s <ludo@gnu.org> wrot=
e:
>> Vincent Legoll <vincent.legoll@gmail.com> skribis:
>>
>>> I came with the attached patch, totally untested, probably wrong for so=
me
>>> cases...
>
> My patch was heuristic, so bound to be wrong sometimes...
>
>> We currently lack a way to specify whether the home directory should be
>> created, which would be useful for =E2=80=98nobody=E2=80=99.
>
> This is the alternative solution, specifying it, always right.

Yeah, that=E2=80=99s what I thought.  It may be useful in other situations =
too.

>> So what about a patch along these lines instead?  It adds a
>> =E2=80=98create-home-directory?=E2=80=99 field to <user-account> and set=
s it to #f for
>> =E2=80=98nobody=E2=80=99.
>
> LGTM, but do I understand correctly: the default value being false, we
> will have to always specify the added param as true in system definitions=
 ?
>
> Why not the other way around, that would not need any modifications of
> current configs.

Oops, I meant it to be #t by default, of course.  Good catch!

Pushed as commits eb56ee027b4c6b5682f69fa885d16e55c4495bd8 and
d03db7434b5b2f1e588c65805d38faea973c3cf0.

Thanks!

Ludo=E2=80=99.