From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#31814: setuid programs are not first in PATH
Date: Tue, 19 Jun 2018 11:29:39 +0200
Message-ID: <87y3fbp1j0.fsf@gnu.org>
References: <87602mu57o.fsf@lassieur.org> <87sh5ljf63.fsf@gnu.org>
	<874li039hu.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37635)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fVCxj-0004sf-JV
	for bug-guix@gnu.org; Tue, 19 Jun 2018 05:30:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fVCxe-0005qm-Lk
	for bug-guix@gnu.org; Tue, 19 Jun 2018 05:30:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47824)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fVCxe-0005qa-J1
	for bug-guix@gnu.org; Tue, 19 Jun 2018 05:30:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fVCxe-00010a-Cq
	for bug-guix@gnu.org; Tue, 19 Jun 2018 05:30:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.31814.D31814.15294005933827.done@debbugs.gnu.org>
In-Reply-To: <874li039hu.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?=
	Lassieur"'s message of "Mon, 18 Jun 2018 08:16:13 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: 31814-done@debbugs.gnu.org

Hello,

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:

[...]

>> diff --git a/gnu/system.scm b/gnu/system.scm
>> index 7cb12a827..d367307a2 100644
>> --- a/gnu/system.scm
>> +++ b/gnu/system.scm
>> @@ -616,9 +616,6 @@ unset PATH
>>  GUIX_PROFILE=3D/run/current-system/profile ; \\
>>  . /run/current-system/profile/etc/profile
>>=20=20
>> -# Prepend setuid programs.
>> -export PATH=3D/run/setuid-programs:$PATH
>> -
>>  # Since 'lshd' does not use pam_env, /etc/environment must be explicitly
>>  # loaded when someone logs in via SSH.  See <http://bugs.gnu.org/22175>.
>>  # We need 'PATH' to be defined here, for 'cat' and 'cut'.  Do this befo=
re
>> @@ -645,6 +642,9 @@ do
>>    fi
>>  done
>>=20=20
>> +# Prepend setuid programs.
>> +export PATH=3D/run/setuid-programs:$PATH
>> +
>>  # Arrange so that ~/.config/guix/current/share/info comes first.
>>  export INFOPATH=3D\"$HOME/.config/guix/current/share/info:$INFOPATH\"
>
> Yes this sounds good.

Pushed as a854525a34c42622a3945ffeb36781ae48a8267e.

Thanks,
Ludo=E2=80=99.