From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#31726: Attempt to use git reference for haskell-mode Date: Mon, 23 Jul 2018 10:20:30 +0200 Message-ID: <87y3e2uzw1.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhW5b-0002dD-OY for bug-guix@gnu.org; Mon, 23 Jul 2018 04:21:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhW5W-0008Ja-PA for bug-guix@gnu.org; Mon, 23 Jul 2018 04:21:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhW5W-0008JV-Ks for bug-guix@gnu.org; Mon, 23 Jul 2018 04:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fhW5W-0000l2-Ca for bug-guix@gnu.org; Mon, 23 Jul 2018 04:21:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: (Jack Hill's message of "Fri, 20 Jul 2018 15:58:55 -0400 (EDT)") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Jack Hill Cc: 31726@debbugs.gnu.org Hello Jack, Jack Hill skribis: > I've returned to working on the haskell-mode fixes for Emacs > 26.1. However, I'm afraid that I'll need a bit more guidance about the > best path forward to prepare a patch that is suitable for inclusion in > Guix. > > When I left off, in addition to your comments, I was concerned with > test failures, so I tried to instead to define the package using a git > reference (patch below (I have not yet worked on the commit > message). Unfortunately, more of the tests fail than before. I was > able to get more of the tests to pass by adding ghc as an input. With > test disabled, I am able to install the package and load it in Emacs. > > A breakdown of the number of failing test is as follows: > 16.1 version with patch -- 4 > git version without ghc -- 11 > git version with ghc -- 7 > > I'm not sure which version to prefer, or how to proceed making that > decision. Version 16.1 was released in September 2016. By moving to > the git version, we would no longer need to run a substitution in > haskell-code-conventions.el as that file has been removed upstream. >From what you=E2=80=99re saying and from the previous discussion, it seems = clear to me that we=E2=80=99d rather use a recent Git snapshot. > Would it be acceptable to disable the tests? If there are 7 failing tests, perhaps that indicates a real issue. Could you take a look at the test log to see if this is something benign? Sometimes it=E2=80=99s just hard-coded /usr/bin file names or simi= lar that cause tests to fail, and that is easy to fix. Now, if haskell-mode has been failing to build for 2+ months, an update without tests is still preferable over the status quo. So if you don=E2=80= =99t see an immediate solution to the test failures, I suppose we could go ahead and apply the patch. Thank you, Ludo=E2=80=99.