unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30265: Fish shell has wrong path variables
@ 2018-01-27  9:11 Meiyo Peng
  2018-01-27 10:36 ` ng0
                   ` (5 more replies)
  0 siblings, 6 replies; 25+ messages in thread
From: Meiyo Peng @ 2018-01-27  9:11 UTC (permalink / raw)
  To: 30265

Hi,

I am using GuixSD 0.14. After upgrading fish shell to latest version(v2.7.1) and
running `guix gc`, fish shell does not work well.
#+BEGIN_EXAMPLE
  meiyo@guix ~$ fish
  fish:
  echo $_ " "; __fish_pwd
               ^
  in command substitution
          called on standard input

  fish:
  __fish_pwd
  ^
  in command substitution
          called on standard input

  in command substitution
          called on standard input

  fish:
  echo $_ " "; __fish_pwd
               ^
  in command substitution
          called on standard input
#+END_EXAMPLE

__fish_pwd is a fish function. It's defined in
`share/fish/functions/__fish_pwd.fish`.  The error message shows that fish
cannot load __fish_pwd's function definition from disk. After doing some
research, I found out that the error was caused by wrong environment variables.

Fish shell is installed in:
#+BEGIN_EXAMPLE
  /gnu/store/ajbbi9cgj9j0my7v5habp0lcysaf2a51-fish-2.7.1/
#+END_EXAMPLE

But the environment variable $fish_function_path does not exist. And these
environment variables point to non-existent paths:
#+BEGIN_EXAMPLE
  __fish_bin_dir /gnu/store/4jkxcz8kpy621ycmqn3rvs0fv6c98h6p-fish-2.7.1/bin
  __fish_datadir /gnu/store/4jkxcz8kpy621ycmqn3rvs0fv6c98h6p-fish-2.7.1/share/fish
#+END_EXAMPLE

Setting $fish_function_path to the correct path reduces the error message.
#+BEGIN_EXAMPLE
  set fish_function_path /gnu/store/ajbbi9cgj9j0my7v5habp0lcysaf2a51-fish-2.7.1/share/fish/functions
#+END_EXAMPLE

`share/fish/config.fish` states $__fish_datadir is set by fish.cpp,
and $fish_function_path is derived from $__fish_datadir.
#+BEGIN_SRC fish
  # __fish_datadir, __fish_sysconfdir, __fish_help_dir, __fish_bin_dir
  # are expected to have been set up by read_init from fish.cpp


  # Set up function and completion paths. Make sure that the fish
  # default functions/completions are included in the respective path.

  if not set -q fish_function_path
      set fish_function_path $configdir/fish/functions $__fish_sysconfdir/functions $__extra_functionsdir $__fish_datadir/functions
  end

  if not contains -- $__fish_datadir/functions $fish_function_path
      set fish_function_path $fish_function_path $__fish_datadir/functions
  end
#+END_SRC

In conclusion, I think some path related variables are not set correctly when
fish is compiled from source code and that caused the bug I met. But since I'm
not good at C++ programming, I will not dive deeper.

I hope that the information provided above is helpful.


Meiyo Peng

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2022-10-10  3:39 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-27  9:11 bug#30265: Fish shell has wrong path variables Meiyo Peng
2018-01-27 10:36 ` ng0
2018-01-27 16:25   ` Ludovic Courtès
2018-01-27 18:19     ` ng0
2018-01-27 12:19 ` Ricardo Wurmus
2018-01-27 13:45   ` Meiyo Peng
2018-01-27 14:13 ` Meiyo Peng
2018-09-19  9:09 ` Pierre Neidhardt
2018-09-19 20:39   ` Ludovic Courtès
2018-09-20 16:09     ` Pierre Neidhardt
2018-09-20 17:00       ` Ricardo Wurmus
2018-09-20 17:12         ` Pierre Neidhardt
2018-09-21 12:03           ` Ludovic Courtès
2018-09-21 12:05       ` Ludovic Courtès
2018-09-21 14:42         ` Pierre Neidhardt
2018-09-21 14:46           ` Ricardo Wurmus
2018-09-21 15:11             ` Pierre Neidhardt
2019-02-02  7:20 ` bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings Meiyo Peng
2019-02-04 22:16   ` Ludovic Courtès
2020-03-30  6:29 ` John Soo
2022-10-07 19:42   ` Maxim Cournoyer
2022-10-07 19:43   ` Maxim Cournoyer
2022-10-07 19:44     ` John Soo
2022-10-07 20:57       ` Mark H Weaver
2022-10-10  3:38         ` Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).