bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

[swedebugia]

$ guix package -i hello --substitute-urls=berlin.guixsd.org
substitute: guix substitute: error: berlin.guixsd.org: invalid URI
guix package: error: build failed: substituter `substitute' died 
unexpectedly

Adding "http://" works:

$ guix package -i wget --substitute-urls=http://berlin.guixsd.org --dry-run
The following package would be upgraded:
    wget    1.19.5 → 1.19.5 
/gnu/store/7jd4nbdamp5bjvvi9acnk4nkk2dzyi71-wget-1.19.5

substitute: updating substitutes from 'http://berlin.guixsd.org'... 100.0%
The following derivations would be built:
    /gnu/store/y6yg5dsfam30v8d7f77bafysqjnbdhgj-profile.drv
    /gnu/store/qdgr96gw7jil08wqhp897mf8qzhhv32b-info-dir.drv
    /gnu/store/66apflyp7b41blxl7s6pv56kq5mfb8h4-fonts-dir.drv
/gnu/store/1d0njpsg6ch60hh5zdkg2lf173kqv32f-ca-certificate-bundle.drv
    /gnu/store/jba4idqg0q0rq0pvdal8scjf9176xx8z-manual-database.drv

$ which guix
/home/sdb/.config/guix/current/bin/guix

$ guix --version
guix (GNU Guix) 1f44934fb6e2cefccbecd4fa347025349fa9ff76

-- 
Cheers
Swedebugia

bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On Mon, 5 Nov 2018 00:41:46 +0100
swedebugia <swedebugia@riseup.net> wrote:

> $ guix package -i hello --substitute-urls=berlin.guixsd.org
> substitute: guix substitute: error: berlin.guixsd.org: invalid URI
> guix package: error: build failed: substituter `substitute' died 
> unexpectedly
> 
> Adding "http://" works:

Hi swedebugia,

I would not consider this a bug: It clearly says that it is not a
proper URI. Also in the documentation all URLs/URIs are written in the
form of 

PROTOCOL://SERVER/PATH.

Closing this one,

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Mon, Nov 05, 2018 at 07:13:22PM +0100, Björn Höfling wrote:
> I would not consider this a bug: It clearly says that it is not a
> proper URI. Also in the documentation all URLs/URIs are written in the
> form of 
> 
> PROTOCOL://SERVER/PATH.

I agree that it's not a bug, but perhaps it's more like a wishlist item.

Ideally, users would not need to concern themselves with implementation
details like protocol selection.

Guix could offer a more unified or simpler interface for authorizing and
selecting substitute servers, and it would handle server addresses,
communication protocols, and key authorization. Currently it's very
ad-hoc.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

[swedebugia]

Hi

On 2018-11-05 20:46, Leo Famulari wrote:
> On Mon, Nov 05, 2018 at 07:13:22PM +0100, Björn Höfling wrote:
>> I would not consider this a bug: It clearly says that it is not a
>> proper URI. Also in the documentation all URLs/URIs are written in the
>> form of
>>
>> PROTOCOL://SERVER/PATH.
> I agree that it's not a bug, but perhaps it's more like a wishlist item.
>
> Ideally, users would not need to concern themselves with implementation
> details like protocol selection.
>
> Guix could offer a more unified or simpler interface for authorizing and
> selecting substitute servers, and it would handle server addresses,
> communication protocols, and key authorization. Currently it's very
> ad-hoc.

+1

It is error prone and hard to understand for newcomers what is going on 
behind the scenes.

I wrote this report from the perspective of a newcomer - ideally they 
should not receive any errors at all if you ask me.

Do you have any ideas how to implement anything better?

A newt-ncurses interface maybe?

-- 
Cheers
Swedebugia

bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On Mon, Nov 05, 2018 at 09:48:55PM +0100, swedebugia wrote:
> Do you have any ideas how to implement anything better?
> 
> A newt-ncurses interface maybe?

I didn't necessarily mean an interactive tool, but a more unified way of
handling substitute server selection. It's a critical aspect of Guix
security so we'd probably want to think on it for a while.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#33261: [substitute-urls] Fails when given only "berlin.guixsd.org"

[Ludovic Courtès]

Hello,

Leo Famulari <leo@famulari.name> skribis:

> On Mon, Nov 05, 2018 at 07:13:22PM +0100, Björn Höfling wrote:
>> I would not consider this a bug: It clearly says that it is not a
>> proper URI. Also in the documentation all URLs/URIs are written in the
>> form of 
>> 
>> PROTOCOL://SERVER/PATH.
>
> I agree that it's not a bug, but perhaps it's more like a wishlist item.
>
> Ideally, users would not need to concern themselves with implementation
> details like protocol selection.
>
> Guix could offer a more unified or simpler interface for authorizing and
> selecting substitute servers, and it would handle server addresses,
> communication protocols, and key authorization. Currently it's very
> ad-hoc.

I agree with the goal, but it’s really a long-term goal with lots of
open issues that go way beyond Guix AIUI (for instance, how do you map a
public key to an actual “address”?.)

So I’m closing it as not-a-bug, but feel free to open a wishlist item
where we can discuss other ways to handle substitutes in the future.

Thanks,
Ludo’.