From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#33300: Automatically detecting binaries in source tarballs
Date: Thu, 08 Nov 2018 09:50:23 +0100
Message-ID: <87y3a454xc.fsf@gnu.org>
References: <87sh0dur48.fsf@gnu.org> <875zx9dof1.fsf@nckx>
	<87zhult0fb.fsf@gnu.org> <20181108005701.2e76fd3d@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKg1r-0007pH-HV
	for bug-guix@gnu.org; Thu, 08 Nov 2018 03:51:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKg1p-0006dK-Km
	for bug-guix@gnu.org; Thu, 08 Nov 2018 03:51:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35984)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gKg1m-0006aK-4G
	for bug-guix@gnu.org; Thu, 08 Nov 2018 03:51:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKg1m-0000GC-0f
	for bug-guix@gnu.org; Thu, 08 Nov 2018 03:51:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33300.B33300.1541667046977@debbugs.gnu.org>
In-Reply-To: <20181108005701.2e76fd3d@scratchpost.org> (Danny Milosavljevic's
	message of "Thu, 8 Nov 2018 00:57:01 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 33300@debbugs.gnu.org

Hello,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> I think it would be good to have guix check for closed-source binaries af=
ter
> unpacking, automatically (including jar files with class files in them).

Oh right, jars are certainly quite common, more than .so files.

>> > No idea if it's worth the trouble/performance hit/false-positive rate,
>> > of course. That's for the ner^Wgods to decide.=20=20
>>=20
>> Yeah I wonder if it would be fruitful.
>
> Marking known-good binaries (whitelisting) is still better than hoping
> we notice some closed-source binary (blacklisting).
>
> It would be a conspicious reminder of what we still have to do - as
> opposed to the situation now where it's mostly in someone's head
> (if at all).

Yeah, that makes sense.

What about adding such a phase in %standard-phases in core-updates-next?
I guess it could check for files that match =E2=80=98elf-file?=E2=80=99 or =
=E2=80=98ar-file?=E2=80=99
and for *.jar.  WDYT?

We must make add a keyword parameter in =E2=80=98gnu-build-system=E2=80=99 =
to make it
easy to disable it and/or to skip specific files.

Any takers?

Thanks,
Ludo=E2=80=99.