unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35542@debbugs.gnu.org
Subject: bug#35542: Installer does not display full backtrace on error
Date: Sat, 04 May 2019 11:43:28 +0200	[thread overview]
Message-ID: <87y33msgmy.fsf@gmail.com> (raw)
In-Reply-To: <20190503174633.otzjizlfjhr4bkca@pelzflorian.localdomain> o--text follows this line--

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

Hello,

> I believe I read about Guile error messages not doing line wrapping in
> terminals on the Guix or Guile mailing lists recently, but I cannot
> find it.  Proper line wrapping may be the better solution.

In fact the textbox where the backtrace is displayed isn't doing any
line wrapping. The attached patch fixes the issue.

Thanks,

Mathieu

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-installer-Reflow-run-file-textbox-page-text.patch --]
[-- Type: text/x-diff, Size: 1129 bytes --]

From f68ded2f134d55c20f98300c0514c4fc18cd1d50 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <m.othacehe@gmail.com>
Date: Sat, 4 May 2019 11:33:33 +0200
Subject: [PATCH] installer: Reflow run-file-textbox-page text.

* gnu/installer/newt/page.scm (run-file-textbox-page): Reflow FILE-TEXT so
that it fits horizontally in the textbox.
---
 gnu/installer/newt/page.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/page.scm b/gnu/installer/newt/page.scm
index 3173d54737..8a32c403df 100644
--- a/gnu/installer/newt/page.scm
+++ b/gnu/installer/newt/page.scm
@@ -559,7 +559,12 @@ ITEMS when 'Ok' is pressed."
                          '())))))
          (form (make-form)))
 
-    (set-textbox-text file-textbox file-text)
+    (set-textbox-text file-textbox
+                      (receive (_w _h text)
+                          (reflow-text file-text
+                                       file-textbox-width
+                                       0 0)
+                        text))
     (add-form-to-grid grid form #t)
     (make-wrapped-grid-window grid title)
 
-- 
2.17.1


  reply	other threads:[~2019-05-04  9:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03  8:59 bug#35542: Installer does not display full backtrace on error pelzflorian (Florian Pelz)
2019-05-03  9:40 ` Danny Milosavljevic
2019-05-03 10:09 ` Ludovic Courtès
2019-05-03 12:15   ` Mathieu Othacehe
2019-05-03 17:46     ` pelzflorian (Florian Pelz)
2019-05-04  9:43       ` Mathieu Othacehe [this message]
2019-05-04 12:24         ` pelzflorian (Florian Pelz)
2019-05-04 12:54           ` Danny Milosavljevic
2019-05-04 16:14             ` Mathieu Othacehe
2019-05-04 16:15               ` Mathieu Othacehe
2019-05-08 14:35                 ` Ludovic Courtès
2019-05-14 12:09                   ` Mathieu Othacehe
2019-05-14 21:02                     ` Ludovic Courtès
2019-05-15  7:30                       ` Mathieu Othacehe
2019-05-04 17:06               ` Danny Milosavljevic
2019-05-04 17:38                 ` pelzflorian (Florian Pelz)
2019-05-04 17:40                   ` pelzflorian (Florian Pelz)
2019-05-04 17:26               ` pelzflorian (Florian Pelz)
2019-05-14 16:01         ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y33msgmy.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=35542@debbugs.gnu.org \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).