From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: bug#35542: Installer does not display full backtrace on error Date: Tue, 14 May 2019 14:09:52 +0200 Message-ID: <87y339i6en.fsf@gmail.com> References: <20190503085927.ib5gudynudeknclm@pelzflorian.localdomain> <87ef5fetnv.fsf@gnu.org> <8736lvka3k.fsf@gmail.com> <20190503174633.otzjizlfjhr4bkca@pelzflorian.localdomain> <87y33msgmy.fsf@gmail.com> <20190504122403.noe5hirk6u3qtmcm@pelzflorian.localdomain> <20190504145409.00768bf6@scratchpost.org> <87pnoy42o7.fsf@gmail.com> <87o94i42md.fsf@gmail.com> <87y33hui96.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:32818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQWGx-0003Wl-5i for bug-guix@gnu.org; Tue, 14 May 2019 08:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQWGu-0002A4-3w for bug-guix@gnu.org; Tue, 14 May 2019 08:11:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQWGr-000284-UB for bug-guix@gnu.org; Tue, 14 May 2019 08:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQWGr-0004fC-Nj for bug-guix@gnu.org; Tue, 14 May 2019 08:11:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87y33hui96.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35542@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey Ludo, > That would ensure we=E2=80=99re only changing Guile=E2=80=99s notion of t= he terminal > width and not interfering with other tools we might launch as child > processes. > > Thoughts? Seems like a better idea indeed. Here's an update patch. About using 200 or a much larger value as Danny suggested, I don't have a strong opinion myself. WDYT? Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-installer-Increase-backtrace-verbosity.patch >From d5f792414d0666d554dc8c7b6fee351bbe7a1c14 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 14 May 2019 14:05:36 +0200 Subject: [PATCH] installer: Increase backtrace verbosity. * gnu/installer.scm (installer-program): Set terminal-width to 200 to make guile backtraces more verbose. --- gnu/installer.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/installer.scm b/gnu/installer.scm index 3dd76707bf..40c06af320 100644 --- a/gnu/installer.scm +++ b/gnu/installer.scm @@ -336,6 +336,8 @@ selected keymap." (gnu services herd) (guix i18n) (guix build utils) + ((system repl debug) + #:select (terminal-width)) (ice-9 match)) ;; Initialize gettext support so that installers can use @@ -359,6 +361,11 @@ selected keymap." (bindtextdomain "xkeyboard-config" #+(file-append xkeyboard-config "/share/locale")) + ;; Initialize 'terminal-width' in (system repl debug) + ;; to a large-enough value to make backtrace more + ;; verbose. + (terminal-width 200) + (let* ((current-installer newt-installer) (steps (#$steps current-installer))) ((installer-init current-installer)) -- 2.17.1 --=-=-=--