From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OP7KA8YuoF+BGwAA0tVLHw (envelope-from ) for ; Mon, 02 Nov 2020 16:07:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YOg/O8UuoF8OEAAAbx9fmQ (envelope-from ) for ; Mon, 02 Nov 2020 16:07:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B35B9404D3 for ; Mon, 2 Nov 2020 16:07:33 +0000 (UTC) Received: from localhost ([::1]:60016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZcMm-0000eD-3D for larch@yhetil.org; Mon, 02 Nov 2020 11:07:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZcMI-0000M7-VH for bug-guix@gnu.org; Mon, 02 Nov 2020 11:07:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZcMI-0005pR-MU for bug-guix@gnu.org; Mon, 02 Nov 2020 11:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZcMI-0008Gg-HE for bug-guix@gnu.org; Mon, 02 Nov 2020 11:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44196: [PATCH 2/3] system: Add store-directory-prefix to boot-parameters. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 02 Nov 2020 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44196 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Received: via spool by 44196-submit@debbugs.gnu.org id=B44196.160433321431764 (code B ref 44196); Mon, 02 Nov 2020 16:07:02 +0000 Received: (at 44196) by debbugs.gnu.org; 2 Nov 2020 16:06:54 +0000 Received: from localhost ([127.0.0.1]:42302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZcMA-0008GG-Df for submit@debbugs.gnu.org; Mon, 02 Nov 2020 11:06:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZcM9-0008G4-0V for 44196@debbugs.gnu.org; Mon, 02 Nov 2020 11:06:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49097) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZcM3-0005mp-R9; Mon, 02 Nov 2020 11:06:47 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52164 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZcM3-0000S4-EO; Mon, 02 Nov 2020 11:06:47 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <878sbvh5j4.fsf@gmail.com> <87y2jvfqon.fsf@gmail.com> <87blgit6qr.fsf@gnu.org> <87361u3sp5.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 02 Nov 2020 17:06:45 +0100 In-Reply-To: <87361u3sp5.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sun, 01 Nov 2020 00:02:14 +0100") Message-ID: <87y2jjivze.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44196@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: Mw6weJcXanWT Hi! Miguel =C3=81ngel Arruga Vivas skribis: > Ludovic Court=C3=A8s writes: >> Could you explain why we need =E2=80=98store-directory-prefix=E2=80=99 i= n addition to >> =E2=80=98store-mount-point=E2=80=99? At first sight, looking at the fie= lds in there, >> these two can seem to be synonymous. > > The difference is subtle unless you use btrfs subvolumes... or bind > mounts, which currently probably would fail as the check is only > performed for btrfs partitions---note to self, think about this and > probably prepare a patch. This check was already implemented, but the > parameter was only provided to grub-configuration-file during > init/reconfigure. > > Should I add an explanation of/link the bug on the commit message? Or > maybe is something like this better? > ---- > ;; Mount point of the store device (as in /etc/fstab's second field) > (store-mount-point boot-parameters-store-mount-point) > ;; Actual path of the store inside of the device at boot time. > (store-directory-prefix boot-parameters-store-directory-prefix) > ---- > > In any case, if that doesn't clarify enough, it can be better understood > with an example: > ----- > Disk configuration: > /dev/xda1: btrfs file system > - /rootfs: subvolume mounted on / > - /gnufs: subvolume mounted on /gnu. > > Therefore the serialized boot-parameters should be: > (boot-parameters > ... > (store > (device "/dev/xda1") > (mount-point "/gnu") > (directory-prefix "/gnufs")) > ...) > ----- (Btrfs no0b here.) Does that mean that /gnu is like a bind-mount of /gnufs in this case? Anyway, I think I got it now, but I feel I=E2=80=99ll have to search again = for this example next time I stumble upon it. ;-) > Writing the last email I though about adding this: > -------------------------------------------------------------------------= ----- > ;; OS's root file system, so it might be a device path like "/dev/sda3= ". > + ;; The 'store-directory-prefix' field contains #f or the actual path of > + ;; the store inside the 'store-device' as seen by GRUB, e.g. it would > + ;; contain "/storefs" if the store is located in that subvolume of a b= trfs > + ;; partition. > (root-device boot-parameters-root-device) > (bootloader-name boot-parameters-bootloader-name) > (bootloader-menu-entries ;list of > boot-parameters-bootloader-menu-entries) > (store-device boot-parameters-store-device) > (store-mount-point boot-parameters-store-mount-point) > + (store-directory-prefix boot-parameters-store-directory-prefix) > -------------------------------------------------------------------------= ----- s/path/file name/, but otherwise LGTM. Thanks for working on these changes! Ludo=E2=80=99.