unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: david larsson <david.larsson@selfhosted.xyz>, 44370@debbugs.gnu.org
Subject: bug#44370: Cuirass fails building (some) packages from a custom-packages input
Date: Mon, 02 Nov 2020 19:04:30 +0100	[thread overview]
Message-ID: <87y2jjab4h.fsf@gnu.org> (raw)
In-Reply-To: <878sbjisl9.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 02 Nov 2020 18:20:02 +0100")


Hey Ludo,

> Now, in Guix proper, the ‘license’ field should always be either a
> <license> or a list of <license> records.  The original code would
> “enforce” that (by failing hard if a package doesn’t follow the rule
> :-)), which I think is good.

You are right, missed that.

> Now, why is David’s use case influenced by the way (gnu ci) handles
> licenses?

David has some custom packages with the license set to "#f", causing the
following backtrace:

--8<---------------cut here---------------start------------->8---
guix/inferior.scm:247:2: ERROR:
  1. &inferior-exception:
      arguments: (quit 1)
      inferior: #<<inferior> pid: pipe socket: #<input-output: string
      7f1b3d1dabd0> close: #<procedure close-pipe (p)> version: (0 1 1) 
packages: #<promise #<procedure 7f1b3d1de940 at guix/inferior.scm:162:32 ()>>
table: #<promise #<procedure 7f1b46b3a780 at guix/inferior.scm:163:32 ()>>>
      stack: ((#f ("ice-9/boot-9.scm" 1763 13)) (raise-exception
      ("ice-9/boot-9.scm" 1666 16)) (raise-exception ("ice-9/boot-9.scm" 1668 
16)) (map1 ("srfi/srfi-1.scm" 585 17)) (map1 ("srfi/srfi-1.scm" 585 29)) (map1
("srfi/srfi-1.scm" 585 29)) (map1 ("srfi/srfi-1.scm" 585 29)) (map1
("srfi/srfi-1.scm" 585 29)) (map1 ("srfi/srfi-1.scm" 585 29)) (map1
("srfi/srfi-1.scm" 585 29)) (map1 ("srfi/srfi-1.scm" 585 29)) (map1
("srfi/srfi-1.scm" 585 29)) (#f ("gnu/ci.scm" 552 38)) (map1
("srfi/srfi-1.scm" 585 17)) (append-map ("srfi/srfi-1.scm" 672 15)) 
(hydra-jobs ("gnu/ci.scm" 516 4)) (#f ("ice-9/eval.scm" 158 9)) (#f
("ice-9/eval.scm" 158 9)) (with-exception-handler ("ice-9/boot-9.scm" 
1735 10)) (call-with-prompt ("ice-9/boot-9.scm" 717 2)) (dynamic-wind
("ice-9/boot-9.scm" 141 2)) (#f (#f #f #f)) (#f ("guix/repl.scm" 92 21)) 
(with-exception-handler ("ice-9/boot-9.scm" 1735 10)) (with-exception-handler
("ice-9/boot-9.scm" 1730 15)) (#f ("guix/repl.scm" 119 7)))
--8<---------------cut here---------------end--------------->8---

As the alist fields such as "description", "long-description",
"license", "home-page", "maintainers" are ignored by Cuirass anyway,
what would you think of removing them?

This should allow custom packages to be built by Cuirass even if they
are not fully defined.

Thanks,

Mathieu




  reply	other threads:[~2020-11-02 18:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 12:42 bug#44370: Cuirass fails building (some) packages from a custom-packages input david larsson
2020-11-01 19:53 ` Mathieu Othacehe
2020-11-01 20:40   ` david larsson
2020-11-02  9:46     ` Mathieu Othacehe
2020-11-02 17:20     ` Ludovic Courtès
2020-11-02 18:04       ` Mathieu Othacehe [this message]
2020-11-03  9:25         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2jjab4h.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=44370@debbugs.gnu.org \
    --cc=david.larsson@selfhosted.xyz \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).