From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MMcOLNVVoF9OAwAA0tVLHw (envelope-from ) for ; Mon, 02 Nov 2020 18:54:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OILXJ9VVoF9PSwAA1q6Kng (envelope-from ) for ; Mon, 02 Nov 2020 18:54:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41B80940416 for ; Mon, 2 Nov 2020 18:54:13 +0000 (UTC) Received: from localhost ([::1]:37820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZey4-0007kw-4L for larch@yhetil.org; Mon, 02 Nov 2020 13:54:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZeww-0006s5-Ql for bug-guix@gnu.org; Mon, 02 Nov 2020 13:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZeww-0002Y1-6S for bug-guix@gnu.org; Mon, 02 Nov 2020 13:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZeww-00047J-5R for bug-guix@gnu.org; Mon, 02 Nov 2020 13:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44196: [PATCH 2/3] system: Add store-directory-prefix to boot-parameters. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 02 Nov 2020 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44196 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44196-submit@debbugs.gnu.org id=B44196.160434314815784 (code B ref 44196); Mon, 02 Nov 2020 18:53:02 +0000 Received: (at 44196) by debbugs.gnu.org; 2 Nov 2020 18:52:28 +0000 Received: from localhost ([127.0.0.1]:42604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZewO-00046W-5y for submit@debbugs.gnu.org; Mon, 02 Nov 2020 13:52:28 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:45630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZewM-00046F-Sl for 44196@debbugs.gnu.org; Mon, 02 Nov 2020 13:52:27 -0500 Received: by mail-wr1-f47.google.com with SMTP id a9so15803883wrg.12 for <44196@debbugs.gnu.org>; Mon, 02 Nov 2020 10:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=sT390ThC7GN7qWM4JsY7jv1WQczZnRxCOI8hsCc9J3E=; b=m9xtoWkMwTCGgO4w45KJo4NpFqW/3YS0wUrBs3ekIUVuUlhJl1HlSJ+kx7RE1E35B6 qwCV5Si+L3qON+Y9bgR/vOzRkvF0+Y3d5hxJiOeHwZmWJZbKkQQbcN+bxKypWuHikDz9 hYU81Gao/pZTn4GQRSxW1g2NDR0lECl8NSCh7KPSFOAqpztP24FIIRVsWrPsDmKwAe7i SV8ALrhQ+nB6C/6t5AYGk2/cP17ddu2Oe6RvxgrZeUpaaKGPqp+YcXgTlBCCBtPa4Lfh AE5ggdokIMWlGoV3oZEgc+63i1eeNZpxk9Q5XpGFUdxW2UxLb5YC6iN2MCfcMHfJYk6X b65g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=sT390ThC7GN7qWM4JsY7jv1WQczZnRxCOI8hsCc9J3E=; b=VgsyxzVRnVo3iuds/cxn+HZbAv69PDN1ugPKlL0tjG3WiTczZNJ7Vy5Ca1ffZGfP1a Wkt6EwxhpKDJU+feKRuUhtc7SQ2nNkCu2J59u0lnU9PecHKNnmU0WfstOwEvqS2ngplL y/F/4uUMcJ0FzUkMRDJaMhMLNB10vtBXTC3JVYSa+Mwa9lxpgpNCYp8XOcCbzEfuPigq CYGGX1tKPgxPkTY5mvDjF4+ho3ywfrWzx/MJMdBvXVXtUXuo2mLDAvnj2oYffMO9pb3F oS40n94EISMbYRbbCqI+WsaR0lS71AnDpIu2SMj8kg9idJ2l1fgjYjmAqAoQwlcUOF4I 70PA== X-Gm-Message-State: AOAM532Tu6+3f5fRo3yDF6oqN5ggSzgIfPSPM+Dk/+yuWWiSLLnyEbPk 0U9jFVeKYNKlso110ZzF2HxGA7zwh+HRkYxo X-Google-Smtp-Source: ABdhPJxy6H/PLQWwOl/jT98FhGUXl/s/CeWNz1blh4v+VVZbubEdETYgl/xaTfDG628x10OPWfij9Q== X-Received: by 2002:a05:6000:1188:: with SMTP id g8mr21139155wrx.422.1604343140510; Mon, 02 Nov 2020 10:52:20 -0800 (PST) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id t6sm19435088wrp.68.2020.11.02.10.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 10:52:19 -0800 (PST) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <878sbvh5j4.fsf@gmail.com> <87y2jvfqon.fsf@gmail.com> <87blgit6qr.fsf@gnu.org> <87361u3sp5.fsf@gmail.com> <87y2jjivze.fsf@gnu.org> Date: Mon, 02 Nov 2020 19:52:18 +0100 In-Reply-To: <87y2jjivze.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 02 Nov 2020 17:06:45 +0100") Message-ID: <87y2jj1ti5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44196@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=m9xtoWkM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: TqmDOXVkn5mI Hello, Ludovic Court=C3=A8s writes: > (Btrfs no0b here.) Does that mean that /gnu is like a bind-mount of > /gnufs in this case? Yes, it's exactly like that for the end user, but that use case isn't implemented yet---it should be useful too for the Hurd and translators---so I have it under my radar. > Anyway, I think I got it now, but I feel I=E2=80=99ll have to search agai= n for > this example next time I stumble upon it. ;-) I also linked this report on the commit message, as it's a non-trivial use case and everybody could need as much info as possible if an error hits---fingers crossed. >> Writing the last email I though about adding this: >> ------------------------------------------------------------------------= ------ >> ;; OS's root file system, so it might be a device path like "/dev/sda= 3". >> + ;; The 'store-directory-prefix' field contains #f or the actual path = of >> + ;; the store inside the 'store-device' as seen by GRUB, e.g. it would >> + ;; contain "/storefs" if the store is located in that subvolume of a = btrfs >> + ;; partition. >> (root-device boot-parameters-root-device) >> (bootloader-name boot-parameters-bootloader-name) >> (bootloader-menu-entries ;list of >> boot-parameters-bootloader-menu-entries) >> (store-device boot-parameters-store-device) >> (store-mount-point boot-parameters-store-mount-point) >> + (store-directory-prefix boot-parameters-store-directory-prefix) >> ------------------------------------------------------------------------= ------ > > s/path/file name/, but otherwise LGTM. I've pushed this change as 2df44e934c9ba14a89d9245d1a4f7cf18e8cfdaa with changes on the rest of the comment as well, as the wording was the same, as I agree that path should refer to a route (where there could be several concrete locations/file names in unix dialect), and file name should be the correct term. > Thanks for working on these changes! Thanks to you for the review, for me this is useful in my daily life (as now I can manage btrfs better too, hehe) and much fun! :-) Happy hacking! Miguel