From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CIHWHeSpql9fcgAA0tVLHw (envelope-from ) for ; Tue, 10 Nov 2020 14:55:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4NbFGeSpql/zdwAA1q6Kng (envelope-from ) for ; Tue, 10 Nov 2020 14:55:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 04FBD940363 for ; Tue, 10 Nov 2020 14:55:31 +0000 (UTC) Received: from localhost ([::1]:41204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcV3R-0006cY-E3 for larch@yhetil.org; Tue, 10 Nov 2020 09:55:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcUxC-0007PJ-27 for bug-guix@gnu.org; Tue, 10 Nov 2020 09:49:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcUxB-0003Zr-Mc for bug-guix@gnu.org; Tue, 10 Nov 2020 09:49:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcUxB-0004Qu-Jo for bug-guix@gnu.org; Tue, 10 Nov 2020 09:49:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#43893: [PATCH] maint: update-guix-package: Optionally add sources to store. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Nov 2020 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43893 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 43893-submit@debbugs.gnu.org id=B43893.160501970516993 (code B ref 43893); Tue, 10 Nov 2020 14:49:01 +0000 Received: (at 43893) by debbugs.gnu.org; 10 Nov 2020 14:48:25 +0000 Received: from localhost ([127.0.0.1]:36902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcUwb-0004Q1-Dd for submit@debbugs.gnu.org; Tue, 10 Nov 2020 09:48:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcUwa-0004Pq-Do for 43893@debbugs.gnu.org; Tue, 10 Nov 2020 09:48:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33685) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcUwV-0003NQ-3y; Tue, 10 Nov 2020 09:48:19 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44526 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcUwU-0000d4-AJ; Tue, 10 Nov 2020 09:48:18 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871rhevfpp.fsf@gnu.org> <20201109192923.29580-1-maxim.cournoyer@gmail.com> <87pn4mqime.fsf@gnu.org> <87zh3pgvhp.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 20 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 10 Nov 2020 15:48:16 +0100 In-Reply-To: <87zh3pgvhp.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Nov 2020 09:02:58 -0500") Message-ID: <87y2j9nu8f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43893@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: daLaXxEIvixV Hi, Maxim Cournoyer skribis: >> Thanks for the patch, that should break the deadlock and allow us to >> proceed with the release! >> >> Next we need to update the =E2=80=98release=E2=80=99 target so >> GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT is set. > > Done! Thanks! >> the extra dependency on Git, > > To me, this script (update-guix-package), is an extension of the > Make-based build system (that's currently it's sole entry-point). There > are already calls to git in this build system (for example, to get the > commit corresponding to HEAD), so I don't perceive it as nasty in this > context. It can also be used as a reminder of things that are missing > in (guile git), for the purists ;-). I think we had everything needed in Guile-Git. >> the extra copies of the whole tree, > > There used to be 3 copies required in total (the Guix checkout, a first > dummy copy in the store, and a final copy in the store). > > Now, we have 2 copies unless GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT is set, > in which case we get a third one in the store. Seems pretty even to me! Right, I stand corrected. >> the extra code > > The extra code make things smoother (better/faster diagnostic), causes > less friction in the workflow (I don't need to go paranoid about my tree > being in pristine condition before 'make update-guix-package' -- I can > rely on Guix computing it deterministically from the last commit). > >> and the shell pipelines, something avoided in the rest of Guix. > > Again, to me this script is a standalone extension of the build system. > It's not defined as a module, cannot be used in the rest of the code > base, so that it does things a bit differently doesn't strike me as bad. Note that quite a few modules started their life under build-aux/. >> Perhaps that suggests there are unwritten coding guidelines we should >> eventually discuss and write. We=E2=80=99ll see! > > That could be nice. Although a linter included with Guile (ala Rust or > Go) and configurable through a config file could have even more impact, > in my opinion. In any case I'd be honored that my code got to be the > spark behind such guidelines/tool, eh :-). I don=E2=80=99t think a linter could flag high-level patterns like the ones we=E2=80=99re talking about, but human-written text could. I hope this discussion can at least help improve mutual understanding on future patches and review processes. Thanks again for your time and patience! Ludo=E2=80=99.