From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WIp4HfzoamKBXAEAbAwnHQ (envelope-from ) for ; Thu, 28 Apr 2022 21:20:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UMPJHfzoamKXCwEA9RJhRA (envelope-from ) for ; Thu, 28 Apr 2022 21:20:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7EBD3BD5D for ; Thu, 28 Apr 2022 21:20:27 +0200 (CEST) Received: from localhost ([::1]:58034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk9ge-00007X-VH for larch@yhetil.org; Thu, 28 Apr 2022 15:20:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk9gI-0008Vz-Px for bug-guix@gnu.org; Thu, 28 Apr 2022 15:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk9gI-0005J8-CU for bug-guix@gnu.org; Thu, 28 Apr 2022 15:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk9gI-0004eI-6p for bug-guix@gnu.org; Thu, 28 Apr 2022 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54786: Installation tests are failing Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 28 Apr 2022 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54786 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 54786-submit@debbugs.gnu.org id=B54786.165117358317838 (code B ref 54786); Thu, 28 Apr 2022 19:20:02 +0000 Received: (at 54786) by debbugs.gnu.org; 28 Apr 2022 19:19:43 +0000 Received: from localhost ([127.0.0.1]:49980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk9fy-0004dd-PG for submit@debbugs.gnu.org; Thu, 28 Apr 2022 15:19:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk9fx-0004dQ-34 for 54786@debbugs.gnu.org; Thu, 28 Apr 2022 15:19:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk9fr-0005IG-T4 for 54786@debbugs.gnu.org; Thu, 28 Apr 2022 15:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=XUtZBeT1Nw+P+JFOnzr8udHM7kNZFiS+Bf3OO9Qx4P0=; b=qCGRk9eVcB33RbvfOc5L 01JnZmhF6Yj73con5ghWUZawROdwSiHgjH1uFvzNPqdvkqiK5s8toqkcC6sNWIA4phfw/yrBEis0Y s5wNczm7rs0to7HbeNg30SRy1srDXkLQM4lCx/PfB+/d7odHg/S25+ZYxZk6bWHXdjzJLiYR5gcEW 4MM3G90HV05ZFv6mQYvXcrcx0fYGjYPDgAuiXjdBOtGXPQHOf3ED3UwZhEFasTSFQUB1JBfynAte/ ObkzkV7v8vJa71bLFuhEUzZM59O4FrEm49Bs3Ljzz9yKHRb/SSy2x590Tm53Uafm+ZeUoN889ccj7 CsBPhqkpc3iI2g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52340 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk9fr-0006bi-GK; Thu, 28 Apr 2022 15:19:35 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87r167rjhv.fsf@gnu.org> <87v8vjwqzk.fsf@gnu.org> <87zgk5brkd.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Flor=C3=A9al?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Apr 2022 21:19:33 +0200 In-Reply-To: <87zgk5brkd.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 28 Apr 2022 09:22:26 +0200") Message-ID: <87y1zpaud6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54786@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651173628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XUtZBeT1Nw+P+JFOnzr8udHM7kNZFiS+Bf3OO9Qx4P0=; b=HBqz3vS2RgCA7kOtPFfnrvOWtn6M6sgWOXOKJSZoWw64UwqI6eYs1LSQPl7pPa7+xoVBMH iRNt1z6Z/a8U4kIIX9lKM+YuSa1UwmR4GBo97y7SnLHJangFZi/PCcOTGkQPpFw9PDdVmt O7WlbncfUVJf79SZres90wev6Sp9ZavJGU8u4OCVbLPgutVuJX8/c83W3R/EPZttSEHU0v rFRoTex8qoMJqTj8xbQ84NGZu/HE6HBetOfy8UERIn2lYY/95pppWUmmB7YaufSjmM1TTq 3xC5ukv8cBdPHHEpXuexBKzv8twImWfjB+IDaT13pPws/foF66R+LCV0SbcXsw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651173628; a=rsa-sha256; cv=none; b=c4kEI5rL24G8Qmvsc9gWDb1VsKIsCaX+035o8W9eTOZGYgNzCHDhCH3B6mxkutoTPzf40M 7Ua5b5ljin4W/rbbMtxL0KBhiYPcKlI0P+lZ1nxiJfJitva0e4E6ATKuTCLwrHAPWVtxJa VHvwkmI5h3lnmDoSza6o8Du2zCJOBsmasL1nPHKf0JDyXxsL6g1Il9llyMm6L+g0RM7MDM Y0TnBTksFqTPiWlLvDuSJJx9sMaRL+170hOOmdLEcXHcflvcIt35jwp02oHgJ6YWSPEis1 8N9uSS4CwBTKwCAIs2TJOEnW4JhugOKN+LH9tXSbmq+lyNqIbV2inT5HKAO/yg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=qCGRk9eV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=qCGRk9eV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E7EBD3BD5D X-Spam-Score: -3.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: I2YU682v3S9x Hi! Mathieu Othacehe skribis: >> * cgit-test (https://ci.guix.gnu.org/build/646812/details) > > The nginx daemon seems to be started multiple times: I believe this is caused by a change of semantics (really: a bug) in the shepherd =E2=80=98start=E2=80=99 method in 0.9.0. Previously, =E2=80=98start=E2=80=99 would wait until the daemon was started= . If the service was being started, shepherd wouldn=E2=80=99t reply until it was done starting it. In 0.9.0, shepherd replies even while it=E2=80=99s waiting for the service = to be started. But as a consequence, it lets you start a service that is already being started, leading to this mess you reported. The proper fix is to better track the status of each service in shepherd, and to prevent double-starts. In the interim, perhaps we can work around that by using a different check to determine whether the service is running. For instance, instead of: (test-assert "nginx running" (marionette-eval '(begin (use-modules (gnu services herd)) (start-service 'nginx)) marionette)) =E2=80=A6 we=E2=80=99d write something like: (test-assert "nginx running" (wait-for-file "/var/run/nginx/pid")) Thoughts? I=E2=80=99ll give that a try. Thanks for the heads-up! Ludo=E2=80=99.