From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2OrLKodN/mJ4lgAAbAwnHQ (envelope-from ) for ; Thu, 18 Aug 2022 16:32:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uEfuKodN/mIjCAAA9RJhRA (envelope-from ) for ; Thu, 18 Aug 2022 16:32:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39E532F934 for ; Thu, 18 Aug 2022 16:32:39 +0200 (CEST) Received: from localhost ([::1]:52326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOgZa-0003Lx-5N for larch@yhetil.org; Thu, 18 Aug 2022 10:32:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOgZ0-0003LL-0u for bug-guix@gnu.org; Thu, 18 Aug 2022 10:32:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOgYz-0005FD-OX for bug-guix@gnu.org; Thu, 18 Aug 2022 10:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOgYz-00009n-KA for bug-guix@gnu.org; Thu, 18 Aug 2022 10:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#57269: [rtl8812au-aircrack-ng-linux-module] Missing Source for hal/rtl8812a/hal8812a_fw.c (and probably other files ending in fw.c) Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 18 Aug 2022 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57269 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jacob K Cc: 57269@debbugs.gnu.org X-Debbugs-Original-Cc: bug-guix@gnu.org, 57269@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1660833101574 (code B ref -1); Thu, 18 Aug 2022 14:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Aug 2022 14:31:41 +0000 Received: from localhost ([127.0.0.1]:56436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOgYe-00009B-7A for submit@debbugs.gnu.org; Thu, 18 Aug 2022 10:31:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:34410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOgYa-00008w-OM for submit@debbugs.gnu.org; Thu, 18 Aug 2022 10:31:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOgYa-0003Kx-J5 for bug-guix@gnu.org; Thu, 18 Aug 2022 10:31:36 -0400 Received: from tobias.gr ([80.241.217.52]:55272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOgYY-0005C4-6y for bug-guix@gnu.org; Thu, 18 Aug 2022 10:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=LvmZAeGiWgqXi 4o4025SD5RQRix3uVW+qltzMk/CVGA=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=m+HqehwHmzBnlFx5XQR3j72ZXtbGRur++OKpt7 u6WZNv4qkauRlh63sotSvvins6FryMJL0fiy9tHSeR8RvGducQMOsCkjrmdyHwgOWlMyyJ 3Ds2ZpiIbx10ZhWuUAps569in6cYEdiSFQf9PggMU8qPFq7FPqRw6JkNTTO/YycUpoCgZ8 jNGPdAKNgAvrIDWHXkn3r9b2WWJLVvXZ+Y3+ggpPEF4cNq0xeg5FehxgwhowkjrENQBuQv vZTzggLijq2oUX8quPsMJr384p4d8+V8fy+b3ykBjJ49LSg5bxkiBumia/QkEY/Rrc1Aj3 A2POHGS5gtd8Ncwz3A3XehAA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 7d8590d5 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 18 Aug 2022 14:31:27 +0000 (UTC) References: Date: Thu, 18 Aug 2022 16:23:30 +0200 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y1vl1v3y.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=80.241.217.52; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Tobias Geerinckx-Rice From: Tobias Geerinckx-Rice via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660833159; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LvmZAeGiWgqXi4o4025SD5RQRix3uVW+qltzMk/CVGA=; b=GWelErsXQ4OWie+nHSMf+7zzqAF4Gyzwg4zBQP/s2LaB5ZoUOc3iJ1PW43J7EbBQJxwZIN nxmPP008Bspprgil7NMQAwesBh9mDmhEYoYmOWcQen1+lNWfGicggcfCarTnuI10oEJ4v1 +k/UOt6P3EzSX9Hcr8394GaDbQ/v3rmYNdhoGt9aBY3jWBlZqcdRdPBN4kmIvnvyDALhqC l6k0jjFVlU8A2MPVDwXDp4sRxHGbzddxDwaJCNAZ9nihyE3opPDxR0o9dYfDcodcLbZLkz uFXoj7oBDS5t262BTdeDrawYfYLTQ4xc5hwwrpT8B+Sbr+oHheLIAolnorbD9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660833159; a=rsa-sha256; cv=none; b=DOFrEr7z13TdfEJZpjZ4dXyRhDx/TtY9KlTYDXmNhej0Tjn9ynsT+eByqm19zt4SwNSERZ ty1r5ILrMfxTrcEfkDHWZnBEfdQMSS1m8QoXa8kTKhYx8NMZQZJ0cyc3IQCCAx4B97HV8t oChvaKJrnlwlT8Z54XYaYCXWVzCIBbqGS126Jw8R9Zd5GlIO7fY6oBtsx3MwKTBxLKp8ZK dy8i4/Ufdq2B0Boaj4gOxJBYRVJvQO2Bqs3D/BfR1sbt+q+cQKrS+WB2zQAPexmXKq2WG3 n8bTPt9rn7ZPjA2b+In1E9GsoZqrrRjt9VTl3GxPyQVrQWbJU2AwCIuQWuTFDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=m+HqehwH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=m+HqehwH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 39E532F934 X-Spam-Score: -5.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: /RP4gzFAAvsY --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Jacob, Jacob K via Bug reports for GNU Guix =E5=86=99=E9=81=93=EF=BC=9A > Files such as hal8812a_fw.c [1] have large arrays that seem to=20 > be binary > firmware encoded in text. My understanding is that source code=20 > is not > available, so I believe the files are nonfree software, Even if free source code exists, we should still remove the blobs=20 and build our own. (Yes, we actually do this for other firmware=20 :-) > the short-term at least, be removed from Guix. Long term it=20 > would be > good to get the source code (via reverse engineering or asking=20 > Realtek), > but I imagine that would take a significant amount of time and=20 > effort (I > do have a Realtek USB Wi-Fi card, maybe not with this exact=20 > firmware > though.). Unfortunately all correct. Another blow to wireless networking=20 with Guix. Attached is a patch removing the=20 rtl8821ce-linux-module and rtl8812au-aircrack-ng-linux-module=20 packages. I didn't apply it yet. Since this case, unlike some others,=20 appears to be straightforward, I don't intend to wait long. Kind regards, T G-R --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Remove-Realtek-WiFi-drivers-with-firmware-blobs.patch Content-Transfer-Encoding: quoted-printable From=20a4650f7dbad4458d3bc907a96a45a334d1d2a086 Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sun, 14 Aug 2022 02:00:00 +0200 Subject: [PATCH 01/12] gnu: Remove Realtek WiFi drivers with firmware blobs. rtl8821ce-linux-module contains, e.g., halhwimg8821c_fw.c and hal8821c_fw.c. rtl8812au-aircrack-ng-linux-module has, e.g., hal8814a_fw.c, hal8812a_fw.c, and hal8821a_fw.c. Each of these examples contains non-free firmware blobs disguised as C arrays. * gnu/packages/linux.scm (rtl8821ce-linux-module) (rtl8812au-aircrack-ng-linux-module): Remove variables. Reported by Jacob K =2D-- gnu/packages/linux.scm | 75 ----------------------------- gnu/system/examples/bare-bones.tmpl | 1 + 2 files changed, 1 insertion(+), 75 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index fb8b4fa5a8..2c1a38b5c4 100644 =2D-- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -1373,81 +1373,6 @@ (define-public lkrg detection of security vulnerability exploits against the kernel.") (license license:gpl2))) =20 =2D(define-public rtl8821ce-linux-module =2D (let ((commit "be733dc86781c68571650b395dd0fa6b53c0a039") =2D (revision "6")) =2D (package =2D (name "rtl8821ce-linux-module") =2D (version (git-version "0.0.0" revision commit)) =2D (source =2D (origin =2D (method git-fetch) =2D (uri (git-reference =2D (url "https://github.com/tomaspinho/rtl8821ce") =2D (commit commit))) =2D (file-name (git-file-name name version)) =2D (sha256 =2D (base32 =2D "00sd7s0582b9jcpfgy0fw6418dwg700mfyizkfr22jf2x140iy70")))) =2D (build-system linux-module-build-system) =2D (arguments =2D (list #:make-flags =2D #~(list (string-append "CC=3D" #$(cc-for-target)) =2D (string-append "KSRC=3D" =2D (assoc-ref %build-inputs =2D "linux-module-builder") =2D "/lib/modules/build")) =2D #:phases =2D #~(modify-phases %standard-phases =2D (replace 'build =2D (lambda* (#:key (make-flags '()) (parallel-build? #t) =2D #:allow-other-keys) =2D (apply invoke "make" =2D `(,@(if parallel-build? =2D `("-j" ,(number->string (parallel-jo= b-count))) =2D '()) =2D ,@make-flags))))) =2D #:tests? #f)) ; no test suite =2D (home-page "https://github.com/tomaspinho/rtl8821ce") =2D (synopsis "Linux driver for Realtek RTL8821CE wireless network ada= pters") =2D (description "This is Realtek's RTL8821CE Linux driver for wireless =2Dnetwork adapters.") =2D (license license:gpl2)))) =2D =2D(define-public rtl8812au-aircrack-ng-linux-module =2D (let ((commit "6d0d9fb56d4d918012a5c7a030b9233cad039cdd") =2D (revision "8")) =2D (package =2D (inherit rtl8821ce-linux-module) =2D (name "rtl8812au-aircrack-ng-linux-module") =2D (version (git-version "5.6.4.2" revision commit)) =2D (source =2D (origin =2D (method git-fetch) =2D (uri (git-reference =2D (url "https://github.com/aircrack-ng/rtl8812au") =2D (commit commit))) =2D (file-name (git-file-name name version)) =2D (sha256 =2D (base32 "012asiy43ik13kl9p97sscdsqq5jihq73s4ws3g5wqqczqcgrsvc"= )) =2D (modules '((guix build utils))) =2D (snippet =2D #~(begin =2D ;; Remove bundled tarballs, APKs, word lists, speadsheets, =2D ;; and other unnecessary unlicenced things. =2D (for-each delete-file-recursively (list "android" =2D "docs" =2D "tools")))))) =2D (supported-systems '("x86_64-linux" "i686-linux")) =2D (home-page "https://github.com/aircrack-ng/rtl8812au") =2D (synopsis "Linux driver for Realtek USB wireless network adapters") =2D (description =2D "This is Realtek's rtl8812au Linux driver for USB 802.11n wireless =2Dnetwork adapters, modified by the aircrack-ng project to support monitor= mode =2Dand frame injection. It provides a @code{88XXau} kernel module that sup= ports =2DRTL8812AU, RTL8821AU, and RTL8814AU chips.") =2D (license license:gpl2+)))) =2D (define-public vhba-module (package (name "vhba-module") diff --git a/gnu/system/examples/bare-bones.tmpl b/gnu/system/examples/bare= -bones.tmpl index 387e4b12ba..ecac4bb3d1 100644 =2D-- a/gnu/system/examples/bare-bones.tmpl +++ b/gnu/system/examples/bare-bones.tmpl @@ -19,6 +19,7 @@ (file-systems (cons (file-system (device (file-system-label "my-root")) (mount-point "/") + (options "atime,lol,ro,shared,shared") (type "ext4")) %base-file-systems)) =20 =2D-=20 2.37.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYv5NQg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15TCYBANu02nNhBjIIb4Ah48wM1SxPIEo4UXgxi8s6Y0ge hMA6AQDPx7jwubq/KG8ptKtjjAYp0IQJGGuc7YsJhqHpo6z3AA== =RXc3 -----END PGP SIGNATURE----- --==-=-=--