From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OM04NZJcmmMejgAAbAwnHQ (envelope-from ) for ; Thu, 15 Dec 2022 00:30:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ENQxNZJcmmOtTwEAauVa8A (envelope-from ) for ; Thu, 15 Dec 2022 00:30:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1183E28A94 for ; Thu, 15 Dec 2022 00:30:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5bCU-0001ST-8U; Wed, 14 Dec 2022 18:30:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5bCN-0001PN-Jt for bug-guix@gnu.org; Wed, 14 Dec 2022 18:30:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5bCN-0005xx-9C for bug-guix@gnu.org; Wed, 14 Dec 2022 18:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5bCM-0002Es-Q0 for bug-guix@gnu.org; Wed, 14 Dec 2022 18:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#60010: [version 1.4.0] AMD screen stays black; modprobe fails Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 14 Dec 2022 23:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60010 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "pelzflorian (Florian Pelz)" Cc: 60010@debbugs.gnu.org Received: via spool by 60010-submit@debbugs.gnu.org id=B60010.16710605878572 (code B ref 60010); Wed, 14 Dec 2022 23:30:02 +0000 Received: (at 60010) by debbugs.gnu.org; 14 Dec 2022 23:29:47 +0000 Received: from localhost ([127.0.0.1]:42156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5bC7-0002EC-7Z for submit@debbugs.gnu.org; Wed, 14 Dec 2022 18:29:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5bC2-0002E3-2m for 60010@debbugs.gnu.org; Wed, 14 Dec 2022 18:29:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5bBv-0005tn-Uq; Wed, 14 Dec 2022 18:29:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rzN+59Xcnsr6GBc75CAItc9M+KxRCm86TwA2zDjeN9A=; b=ZHO/s5YVvo7SxuCoA49B CfLp809EyscpYj3R9TKyGu+1/EDK3wOUkj162z8Os2WOPZdgWHItUHqTAthuWbWEeP4iMz10g2avc /rBO3VWBJr+uGNi7ja3hqU9NGb0WvVUbnUaFjcx+J4EmUCLIjiAsdwphcgP8lPGoXLP3jO9iQKAVR YwI2nMpC8QrmkXa/LtrU1Q0cOXEH2z8UoSy18k61VEnES2W9yIyEH15l+YAZ4EHKHf/Ugq20TQ3ND KZzBVcCCcIBeff54JAGHEjoiaVGzVyQKv5GLLTeG1aDVdm13T7g/H1gU2HxW7P3RxCp/ifBAYkqNC xS4hlrfsNNUkzg==; Received: from [82.66.71.168] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5bBu-0006ah-Tm; Wed, 14 Dec 2022 18:29:35 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y1rcegff.fsf@pelzflorian.de> <87wn6wyzvn.fsf@gnu.org> <875yefy665.fsf@gnu.org> <87o7s7zcum.fsf@pelzflorian.de> <87k02vwj5c.fsf@gnu.org> <87r0x2f62t.fsf@pelzflorian.de> Date: Thu, 15 Dec 2022 00:29:32 +0100 In-Reply-To: <87r0x2f62t.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Wed, 14 Dec 2022 14:49:46 +0100") Message-ID: <87y1r9r2cj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671060626; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rzN+59Xcnsr6GBc75CAItc9M+KxRCm86TwA2zDjeN9A=; b=GAsNCgsbCuFWAb2x+vTeGTqFeMrYYiuUGm490EX7rI/TobxoAlxRXxwTfY2rzVNWbJs66o sjflXZgnsQPjbnEj/iT4f/FaH02e9sVBPulkFQam+obLfehlFP5s1fWIcgQo+BrH3s89LE Ea5IUWKv8+YtXzwSi5PMpM/Jp02qB+6IAWNQ7bOx8qHp/bUD1rtT7Q8qN8sQjNxmrFqUEI KGac/Hwk5e+ZT+c5msq92TmnIGFR7Y1SAEektlmRxnW14G77P7QO2hVhi3mqwP/teS/Vkj 1xiAdlgAXghBm+xagDK8fAWtNMavAIO1EGUsc8bzrTPOao2Cllgo3KpAsvbozw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="ZHO/s5YV"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671060626; a=rsa-sha256; cv=none; b=jmY+y/9L6XNwu7FmiC83sTaOfM9RyiPcDo5gwmh9UZ4m4P9k7mguntP/BwxC4oL67WPP1S i0ZHAZuAzvxvtrdNk9ubtJu3nCCOLJGZg2bvg5FKi+LjSQeyA6rDXFZ4fukh/b7zomTLhW 8ykTq5/7sSbL1Pl2uTzhx9/KqqO0PC60jqTtxVMHZ9O1pEGQvi9OE2mSOlGD9D84HqX6/R QnDHRmMngHgPbVqv9Iw5UfWvIX+yL8EBVkzijPPYhID6vVF7awgW49buHVJRDjL/T7WsIj ZTg9srYpnkArA3XGB6pfn/xqGfHxlHK2bEl2uhHr7ZqdwT40S20xb93zufjx8w== X-Migadu-Spam-Score: -2.87 X-Spam-Score: -2.87 X-Migadu-Queue-Id: 1183E28A94 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="ZHO/s5YV"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: Aoz5h3UQPaPL --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "pelzflorian (Florian Pelz)" skribis: > Ludovic Court=C3=A8s writes: >> Do you see hints as to whether uvesafb gets loaded? >> >> You can do that by adding =E2=80=9Cconsole=3DttyS0=E2=80=9D to the kerne= l arguments and by >> passing =E2=80=98-serial stdio=E2=80=99 to QEMU. > > This serial output shows nothing about uvesafb, but dmesg contains about > uvesafb exactly the same modprobe failure as initially without > LINUX_MODULE_DIRECTORY. Oooh. =E2=80=98invoke=E2=80=99 uses =E2=80=98system*=E2=80=99, and in shep= herd 0.9.3, =E2=80=98system*=E2=80=99 is implemented in terms of =E2=80=98fork+exec-command=E2=80=99, which only pas= ses the environment variables listed in =E2=80=98default-environment-variables=E2= =80=99 by default. Thus, (setenv "LINUX_MODULE_DIRECTORY" =E2=80=A6) had no effect o= n the child process; it just wouldn=E2=80=99t see LINUX_MODULE_DIRECTORY. I think the patch below will be good=E2=80=A6 or very close to it. Lemme know! Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/system/install.scm b/gnu/system/install.scm index f6f1923121..e524729baf 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -289,11 +289,21 @@ (define (uvesafb-shepherd-service _) (provision '(maybe-uvesafb)) (requirement '(file-systems)) (start #~(lambda () - (or (file-exists? "/dev/fb0") + (unless (file-exists? "/dev/fb0") + ;; In shepherd 0.9.3, 'system*' is implemented in terms + ;; of 'fork+exec-command'. Thus, set + ;; 'default-environment-variables' to pass an extra + ;; variable to the child process. + (parameterize ((default-environment-variables + `("LINUX_MODULE_DIRECTORY=/run/booted-system/kernel/lib/modules" + ,(environ)))) + ;; TODO: Use 'load-linux-modules-from-directory' + ;; instead. (invoke #+(file-append kmod "/bin/modprobe") "uvesafb" (string-append "v86d=" #$v86d "/sbin/v86d") - "mode_option=1024x768")))) + "mode_option=1024x768")) + #t))) (respawn? #f) (one-shot? #t)))) --=-=-=--