unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Brian Cully via Bug reports for GNU Guix <bug-guix@gnu.org>
Cc: 63261-done@debbugs.gnu.org, Brian Cully <bjc@spork.org>
Subject: bug#63261: Recent changes to git config cause errors for non-committers
Date: Sat, 06 May 2023 23:34:42 -0400	[thread overview]
Message-ID: <87y1m024rx.fsf@gmail.com> (raw)
In-Reply-To: <874jospdr2.fsf@psyduck.jhoto.kublai.com> (Brian Cully via Bug reports for's message of "Thu, 04 May 2023 06:47:32 -0400")

Hi,

Brian Cully via Bug reports for GNU Guix <bug-guix@gnu.org> writes:

> I've run into two issues with the recent changes to git config
> integration:
>
> 1) All commits must now be signed, even if you're not a
> committer. This breaks just tons of things, including rebasing. I'm
> not sure how to fix this without just disabling that configuration
> line altogether.
>
> 2) Some ‘make’ rules now require git to be installed so that ‘git
> config’ can add ‘etc/git/gitconfig’ to the local configuration. So,
> for instance, ‘guix shell --pure -D guix -- make’ will now fail. Calls
> to git should be prefixed with a test to see if there is a git
> executable in the path.

2. has been fixed (also by Ludovic, ah!).  I'm not sure a good solution
can be found for 1. but it seems reasonable to me that contributors
working on Guix learn to sign their commits with GnuPG; that way they
are on the right path to become a Guix committer, already getting up to
speed with the required practices.

Closing, but we can continue discussing it.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-05-07  3:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 10:47 bug#63261: Recent changes to git config cause errors for non-committers Brian Cully via Bug reports for GNU Guix
2023-05-04 13:38 ` Maxim Cournoyer
2023-05-04 14:06 ` bug#63261: [PATCH] Makefile.am: Only auto-configure Git when available Maxim Cournoyer
2023-05-07  3:34 ` Maxim Cournoyer [this message]
2023-05-13 19:03   ` bug#63261: Recent changes to git config cause errors for non-committers Leo Famulari
2023-05-15 13:38     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1m024rx.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=63261-done@debbugs.gnu.org \
    --cc=bjc@spork.org \
    --cc=bug-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).