From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] gnu: Add psutils.
Date: Mon, 21 Jan 2013 21:15:20 +0100 [thread overview]
Message-ID: <87wqv68f8n.fsf@gnu.org> (raw)
In-Reply-To: <201301202333.31367.andreas@enge.fr> (Andreas Enge's message of "Sun, 20 Jan 2013 23:33:31 +0100")
Hi!
Andreas Enge <andreas@enge.fr> skribis:
> The attached patch adds psutils. Its license is homebrewed:
> http://packages.debian.org/changelogs/pool/main/p/psutils/current/copyright
> Does it qualify as "bsd-like"?
It looks like BSD-3 to me, or at least “BSD-like”.
> If not, would it make sense to add a license "other" to licenses.scm,
> which takes the same parameters as "bsd-like"?
I think (guix licenses) should export the constructor, but under the
name ‘make-license’ to avoid clashes with the ‘license’ field in
‘package’ records.
> + (substitute* "Makefile"
> + (("/usr/local/bin/perl") (string-append perl "/bin/perl")))
Please align the opening paren under the ‘u’. (Perhaps your editor can
be tought to always do that?)
> + (substitute* "Makefile"
> + ((" install.include") ""))
> + ;; drop installation of non-free files
> + ))
Please put the comment above the line it refers to, and move closing
parentheses to the end of the line.
Nitpickingly yours, ;-)
Ludo’.
next prev parent reply other threads:[~2013-01-21 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 22:33 [PATCH] gnu: Add psutils Andreas Enge
2013-01-21 20:15 ` Ludovic Courtès [this message]
2013-01-21 20:45 ` Andreas Enge
2013-01-21 22:43 ` Ludovic Courtès
2013-01-23 20:07 ` Andreas Enge
2013-01-23 23:10 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqv68f8n.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=andreas@enge.fr \
--cc=bug-guix@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).