unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] gnu: Add dwm.
Date: Wed, 03 Apr 2013 10:20:41 +0200	[thread overview]
Message-ID: <87wqskrpnq.fsf@gnu.org> (raw)
In-Reply-To: <1364769060-31557-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Mon, 1 Apr 2013 00:31:00 +0200")

Hi!

Cyril Roelandt <tipecaml@gmail.com> skribis:

> This patch can be applied again the xorg branch. It adds dwm, which may not be
> extremely useful since, according to its developers "because dwm is customized
> through editing its source code, it’s pointless to make binary packages of it".

Interesting.  :-)

> I had to turn '${CC}' into 'gcc' in the Makefile, because ${CC} was 'cc', and
> there was no 'cc' command available. Would it make sense to create a symlink
> when installing gcc ?

Dunno.  It’s the first time we see this, no?

> +         (lambda* (#:key outputs #:allow-other-keys)
> +          (let ((out (assoc-ref outputs "out")))
> +           (zero?
> +            (system* "make" "install"
> +             (string-append "DESTDIR=" out) "PREFIX="))))

“(string-append” should be aligned with "make".

Is it really DESTDIR and not PREFIX that must be set?

> +    (license "x11")))

Typo: should be ‘x11’ (the variable).

Thanks!

Ludo’.

  parent reply	other threads:[~2013-04-03  8:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-31 22:31 [PATCH] gnu: Add dwm Cyril Roelandt
2013-03-31 22:39 ` Cyril Roelandt
2013-04-03  8:22   ` Ludovic Courtès
2013-04-03 11:01   ` Nikita Karetnikov
2013-04-03 12:00     ` Ludovic Courtès
2013-04-03 20:34       ` Nikita Karetnikov
2013-04-04 16:49         ` Nikita Karetnikov
2013-04-03  8:20 ` Ludovic Courtès [this message]
2013-04-03 21:41   ` Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqskrpnq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=bug-guix@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).