From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: bug#25573: Adding btrfs support may break reconfigured system Date: Sun, 29 Jan 2017 21:03:56 +0300 Message-ID: <87wpddzqsz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXtqb-0002I6-II for bug-guix@gnu.org; Sun, 29 Jan 2017 13:05:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXtqY-0004U4-Bk for bug-guix@gnu.org; Sun, 29 Jan 2017 13:05:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXtqY-0004Ty-91 for bug-guix@gnu.org; Sun, 29 Jan 2017 13:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXtqX-0003XM-Ve for bug-guix@gnu.org; Sun, 29 Jan 2017 13:05:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXtpe-0002Gl-C0 for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXtpb-0004CK-6B for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:06 -0500 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXtpa-0004Br-Ug for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:03 -0500 Received: by mail-lf0-x242.google.com with SMTP id q89so29737225lfi.1 for ; Sun, 29 Jan 2017 10:04:01 -0800 (PST) Received: from leviafan ([217.107.194.128]) by smtp.gmail.com with ESMTPSA id s63sm3061971lja.49.2017.01.29.10.03.58 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jan 2017 10:03:59 -0800 (PST) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 25573@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, recently I found that "guix system" makes a "broken" system for me. When I boot a freshly created system, I get something like this: In procedure <...> at ./gnu/build/file-systems.scm:282:4 (device) In procedure fport_seek: Invalid argument and I'm thrown at the Guile promt. The same problem (well, I think it's the same) was also reported by roptat on #guix: https://gnunet.org/bot/log/guix/2017-01-28#T1277485 After bisecting the guix git checkout, I found that commit b1a505baf6=C2=B9 was the first one where my system starts to fail. And indeed when I reverted this commit on the latest master, guix built a working system. Moreover, the following simple diff (it's a partial revert of that commit) "fixes" guix for me: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fix-btrfs.diff diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 6e5c6aa..f05e035 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -294,15 +294,11 @@ partition field reader that returned a value." (define %partition-label-readers (list (partition-field-reader read-ext2-superblock - ext2-superblock-volume-name) - (partition-field-reader read-btrfs-superblock - btrfs-superblock-volume-name))) + ext2-superblock-volume-name))) (define %partition-uuid-readers (list (partition-field-reader read-ext2-superblock - ext2-superblock-uuid) - (partition-field-reader read-btrfs-superblock - btrfs-superblock-uuid))) + ext2-superblock-uuid))) (define read-partition-label (cut read-partition-field <> %partition-label-readers)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't have btrfs anywhere (only ext4). During bisecting experiments I used the attached system config (but the config shouldn't matter I think as I tried various variants, and all gave me the same result). Any idea how to dig further? Perhaps there is something I can do in the Guile prompt. =C2=B9 http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Db1a505baf61cc= 771197eb44af9173f31d2bace46 --=-=-= Content-Type: text/x-scheme Content-Disposition: attachment; filename=bare-bones.scm (use-modules (gnu)) (operating-system (host-name "leviafan") (timezone "Europe/Moscow") (locale "en_US.utf8") (bootloader (grub-configuration (device "/dev/sda"))) (initrd (lambda (fs . args) (apply base-initrd fs #:extra-modules '("sata_nv") ; for my HDD args))) (file-systems (cons (file-system (device "guix") (title 'label) (mount-point "/") (type "ext4")) %base-file-systems)) (users (cons (user-account (name "al") (group "users") (supplementary-groups '("wheel" "audio" "video")) (home-directory "/home/al")) %base-user-accounts)) (packages %base-packages) (services (cons* (console-keymap-service "dvorak") %base-services))) --=-=-=--