From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25917: operating-system file-system with (check? #t) but
	(needed-for-boot #f) pauses boot until user interaction
Date: Sat, 11 Mar 2017 12:21:28 +0100
Message-ID: <87wpbw83ev.fsf@gnu.org>
References: <20170301173838.797d5dbc@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cmf65-00081U-FK
	for bug-guix@gnu.org; Sat, 11 Mar 2017 06:22:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cmf62-0000aF-DQ
	for bug-guix@gnu.org; Sat, 11 Mar 2017 06:22:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:52142)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cmf62-0000aB-AF
	for bug-guix@gnu.org; Sat, 11 Mar 2017 06:22:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cmf62-0006cM-4m
	for bug-guix@gnu.org; Sat, 11 Mar 2017 06:22:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25917.B25917.148923130225408@debbugs.gnu.org>
In-Reply-To: <20170301173838.797d5dbc@scratchpost.org> (Danny Milosavljevic's
	message of "Wed, 1 Mar 2017 17:38:38 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 25917@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> If one has a operating-system file-system with (check? #t) but (needed-fo=
r-boot #f), the next boot after reconfiguring will boot into a Guile REPL b=
ecause the initrd doesn't contain the fsck tool for that file system (becau=
se all the file-systems with (needed-for-boot #f) have been filtered out). =
Therefore, the normal boot process breaks.
>
> Possible fixes:
> - If (check? #t) but (needed-for-boot? #f), include the tool anyway, XOR
> - If (check? #t) but (needed-for-boot? #f), don't check anyway

I think we should do the latter.  When needed-for-boot? is #f, the check
is performed by the Shepherd service that takes care of the file system:

  https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/base.scm#n291

Can you look into it?

Thanks for the report!

Ludo=E2=80=99.