From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#30760: guix system init broken on non GuixSD
Date: Sat, 10 Mar 2018 00:19:52 +0100
Message-ID: <87woykx2ef.fsf@gnu.org>
References: <20180309173530.wfdw356rf53tesck@doom>
	<20180309231543.2ede5fa1@scratchpost.org> <87efksyioy.fsf@gnu.org>
	<20180309235221.49e695d9@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euRJ1-0000OO-Sa
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:20:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euRIw-00011A-RC
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:20:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45040)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1euRIw-000110-Mj
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:20:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euRIw-0006lU-Eo
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:20:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.30760.D30760.152063759725981.done@debbugs.gnu.org>
In-Reply-To: <20180309235221.49e695d9@scratchpost.org> (Danny Milosavljevic's
	message of "Fri, 9 Mar 2018 23:52:21 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30760-done@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> [huge build]
>> The current tradeoff is to make that diagnostic based on the running
>> kernel, even if it=E2=80=99s an approximation.
>
> Ah, good point.
>
>> If that=E2=80=99s fine with you I=E2=80=99d like to fix this bug with th=
e conservative
>> patch below.
>
> Sure, looks good.

Pushed as 8d5c14edf5a6d01f859b1aa00c836ffdb5ddecf4.

> While we are approximating we could also in a later version fall back to
> (the host system's) "`cat /proc/sys/kernel/modprobe` --showconfig" - it
> could be used to find aliases.
>
> But maybe that would make it brittle.  Hmm...

Yeah, I don=E2=80=99t think it=E2=80=99d make a big difference.

BTW, we should add a =E2=80=98--skip-checks=E2=80=99 option to =E2=80=98gui=
x system=E2=80=99 so that
users can skip those checks.  That=E2=80=99d provide an escape hatch in case
=E2=80=98check-device-initrd-modules=E2=80=99 makes the wrong diagnostic.

Thoughts?

Ludo=E2=80=99.