From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: brettg@posteo.net
Cc: Sergiu Marton <brown121407@gmail.com>,
38782@debbugs.gnu.org,
bug-Guix <bug-guix-bounces+brettg=posteo.net@gnu.org>,
bug-Guix <bug-guix-bounces+brettg=gnu.org@gnu.org>
Subject: bug#38782: portaudio fails to build
Date: Sun, 29 Dec 2019 11:07:58 +0100 [thread overview]
Message-ID: <87woafzbpd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <da5ef7bf9763ce6de1c6c77216dde87c@posteo.net> (brettg@posteo.net's message of "Sun, 29 Dec 2019 10:45:33 +0100")
brettg@posteo.net writes:
> On 29.12.2019 10:43, Nicolas Goaziou wrote:
>> Hello,
>>
>> brettg@posteo.net writes:
>>
>>> I would personally comment the reason for disabling parallel builds
>>
>> You mean as a comment in the package definition? I checked other
>> definitions, comments in this situation, if any, are terse. E.g.,
>> ";fails on some systems".
>>
>>> and affix this bug number to the commit sub-header message.
>>
>> I added the bug reference to the commit message. Do you mean it should
>> be moved right after the commit title (separated by a blank line)?
>>
>> Regards,
>
> On a second look, your commit message is fine. And the `; fails on
> some systems` seems fine to me. Sorry, I am quite sleep deprived right
> now. :)
Great. I applied the patch. All the credit goes to Ricardo Wurmus for
the fix.
prev parent reply other threads:[~2019-12-29 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 21:48 bug#38782: portaudio fails to build Sergiu Marton
2019-12-28 23:08 ` Ricardo Wurmus
2019-12-29 7:48 ` Sergiu Marton
2019-12-29 8:43 ` Nicolas Goaziou
2019-12-29 8:59 ` Sergiu Marton
2019-12-29 9:36 ` brettg
2019-12-29 9:43 ` Nicolas Goaziou
2019-12-29 9:45 ` brettg
2019-12-29 10:07 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woafzbpd.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=38782@debbugs.gnu.org \
--cc=brettg@posteo.net \
--cc=brown121407@gmail.com \
--cc=bug-guix-bounces+brettg=gnu.org@gnu.org \
--cc=bug-guix-bounces+brettg=posteo.net@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).