From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#38940: \x1b]8; ;
 OSC character displayed on hyperlinks shown after calls to `guix
 describe` or `guix show` on mate-terminal 1.12.1 (Trisquel 8)
Date: Thu, 09 Jan 2020 22:23:48 +0100
Message-ID: <87woa0tjbv.fsf@gnu.org>
References: <1578206891.2605.33.camel@gmail.com>
 <CAJ3okZ3Rso90gqLknkcZd3j=uyNFU5B_=vwuJ47eXfyTX-nr=A@mail.gmail.com>
 <1578342380.2215.13.camel@gmail.com>
 <CAJ3okZ0xigUV3offJrTqVnXcgB_=1XevdL7f3wxz15=cwy_0+w@mail.gmail.com>
 <1578475589.2665.55.camel@gmail.com> <877e21eiy9.fsf@gnu.org>
 <CAJ3okZ0VPZRL+ZXq5MssmyrZD2z-zqJZJc7_1A_vHSxjfzRWRQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:42248)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfHf-0002PL-3z
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:24:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfHe-0000N8-2c
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:24:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47180)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ipfHd-0000Lm-Si
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:24:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfHd-0000ww-Ll
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:24:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38940.B38940.15786050393642@debbugs.gnu.org>
In-Reply-To: <CAJ3okZ0VPZRL+ZXq5MssmyrZD2z-zqJZJc7_1A_vHSxjfzRWRQ@mail.gmail.com>
 (zimoun's message of "Thu, 9 Jan 2020 13:17:33 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Calvin Heim <frofroggy@gmail.com>, 38940@debbugs.gnu.org

Hi!

zimoun <zimon.toutoune@gmail.com> skribis:

> On Wed, 8 Jan 2020 at 22:28, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
>
>> The theory is that terminals should ignore OSC codes that they do not
>> support.  Good=E2=80=99ol xterm, for instance, silently ignores those hy=
perlink
>> codes, whereas GNOME Terminal interprets them nicely.
>
> H=C3=A9h=C3=A9! It is what the comment you wrote in `supports-hyperlinks?=
' says. :-)
>
> 1. Instead of INSIDE_EMACS, the variable name NO_SUPPORT_HYPERLINK or
> other seems more meaningful. Maybe?

Actually the goal was to remove =E2=80=98INSIDE_EMACS=E2=80=99 from there o=
nce a
widespread-enough Emacs version supports it, which could be within a
year.  And since other terminals are supposed to ignore it altogether, I
would rather not add a special environment variable.

WDYT?

> 2. The comment should go in the docstring.

I tend to write =E2=80=9Cimplementation details=E2=80=9D as comments, while=
 keeping pure
descriptions of the interface as docstrings; I think it=E2=80=99s OK.  :-)

Ludo=E2=80=99.