From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +ErVKKz/h1+9EQAA0tVLHw (envelope-from ) for ; Thu, 15 Oct 2020 07:52:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GFukJKz/h1+nXAAAB5/wlQ (envelope-from ) for ; Thu, 15 Oct 2020 07:52:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86A8D9401D0 for ; Thu, 15 Oct 2020 07:52:11 +0000 (UTC) Received: from localhost ([::1]:40558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSy3W-0007G3-Fu for larch@yhetil.org; Thu, 15 Oct 2020 03:52:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSy3O-0007Dz-A7 for bug-guix@gnu.org; Thu, 15 Oct 2020 03:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSy3O-0008Tc-1X for bug-guix@gnu.org; Thu, 15 Oct 2020 03:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSy3O-0007fY-0W for bug-guix@gnu.org; Thu, 15 Oct 2020 03:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 15 Oct 2020 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43984 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: pkill9 Received: via spool by 43984-submit@debbugs.gnu.org id=B43984.160274826329413 (code B ref 43984); Thu, 15 Oct 2020 07:52:01 +0000 Received: (at 43984) by debbugs.gnu.org; 15 Oct 2020 07:51:03 +0000 Received: from localhost ([127.0.0.1]:54091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy2R-0007eF-8V for submit@debbugs.gnu.org; Thu, 15 Oct 2020 03:51:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy2Q-0007dV-Er for 43984@debbugs.gnu.org; Thu, 15 Oct 2020 03:51:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45861) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSy2K-00085H-Nd; Thu, 15 Oct 2020 03:50:56 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51812 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSy2K-0000yd-2i; Thu, 15 Oct 2020 03:50:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201014015558.09d6702a@runbox.com> Date: Thu, 15 Oct 2020 09:50:54 +0200 In-Reply-To: <20201014015558.09d6702a@runbox.com> (pkill9@runbox.com's message of "Wed, 14 Oct 2020 01:55:58 +0100") Message-ID: <87wnzsapwh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43984@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: rzXAc80+wMfA Hi, pkill9 skribis: > As expected, if you attempt to graft a package's dependency, and it's > name + version is different length to the original dependency, then it > will fail to graft. Yes, that=E2=80=99s expected, but perhaps the manual could state it more prominently? > Maybe if the length/version is different, then a symlink could be > created in the store pointing to the new dependency, with a > name/version that matches the length of the original dependency's store > name? Perhaps this new name/version could be something like > /gnu/store/...-original-dependency-name-gggggg, where 'g..' matches the > length of the version of the original dependency. The many 'g's would > make it clear that it is a graft. Then if someone looks in the store, > they would see it's a symlink too. That only works if the new name is shorter than the old name though. When the new name is longer (which is a more common case in our experience when introducing package replacements, typically because the new version string is longer), nothing can be done. I=E2=80=99m tempting to keep things as is. Thoughts? Ludo=E2=80=99.