From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kPahMYtcpV+pVwAA0tVLHw (envelope-from ) for ; Fri, 06 Nov 2020 14:24:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CAmKLYtcpV+HeQAAbx9fmQ (envelope-from ) for ; Fri, 06 Nov 2020 14:24:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 536AA9400D3 for ; Fri, 6 Nov 2020 14:24:11 +0000 (UTC) Received: from localhost ([::1]:40836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb2ew-0000vj-Al for larch@yhetil.org; Fri, 06 Nov 2020 09:24:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb2eo-0000vT-W1 for bug-guix@gnu.org; Fri, 06 Nov 2020 09:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kb2eo-0003BL-Dk for bug-guix@gnu.org; Fri, 06 Nov 2020 09:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kb2eo-00078O-7j for bug-guix@gnu.org; Fri, 06 Nov 2020 09:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44428: Graphical Installer window clipping on "small" displays Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 06 Nov 2020 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44428 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Eric Bavier Received: via spool by 44428-submit@debbugs.gnu.org id=B44428.160467263727411 (code B ref 44428); Fri, 06 Nov 2020 14:24:02 +0000 Received: (at 44428) by debbugs.gnu.org; 6 Nov 2020 14:23:57 +0000 Received: from localhost ([127.0.0.1]:55449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kb2ei-000783-O3 for submit@debbugs.gnu.org; Fri, 06 Nov 2020 09:23:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kb2eg-00077p-L3 for 44428@debbugs.gnu.org; Fri, 06 Nov 2020 09:23:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37783) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb2eZ-00034Q-EK; Fri, 06 Nov 2020 09:23:48 -0500 Received: from [2a01:e0a:19b:d9a0:9dba:8b9f:8322:f2bc] (port=60920 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kb2eY-0006S0-O5; Fri, 06 Nov 2020 09:23:47 -0500 From: Mathieu Othacehe References: Date: Fri, 06 Nov 2020 15:23:44 +0100 In-Reply-To: (Eric Bavier's message of "Tue, 03 Nov 2020 22:00:43 -0600") Message-ID: <87wnyyk1hr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44428@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: 9yOYjdG54/XI --=-=-= Content-Type: text/plain Hello Eric, > I can understand if this is not a configuration that we need to > "support", but was hoping that there might be something that could bedone to help. > These pictures were taken using the 1.1.0 release installer, but an > installer I created for i686 at commit 8a7bbc35 seems to behave the > same. Thanks for the detailed bug report. Here's a patch improving the situation. I tested it with: --8<---------------cut here---------------start------------->8--- qemu-system-x86_64 -m 1024 -cdrom image.iso -display sdl -vga none -device virtio-vga,xres=800,yres=600 --8<---------------cut here---------------end--------------->8--- The problem is that three pages are still overflowing in 800x600: * The welcome page. * The partitioning page. * The final configuration page. Could you check if you share the same observations on your hardware? Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-installer-Limit-listbox-height.patch >From 0e13414b5bbbb96cc6b8d83d2974cfea8ff8d073 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Fri, 6 Nov 2020 10:59:54 +0100 Subject: [PATCH] installer: Limit listbox height. Partially fixes: . * gnu/installer/newt/page.scm (default-listbox-height): New variable. (run-listbox-selection-page): Use it. * gnu/installer/newt/wifi.scm (wifi-listbox-height): Ditto. * gnu/installer/newt/network.scm (run-technology-page): Set the maximum listbox height to 5. * gnu/installer/newt/ethernet.scm (run-ethernet-page): Ditto. --- gnu/installer/newt/ethernet.scm | 2 +- gnu/installer/newt/network.scm | 2 +- gnu/installer/newt/page.scm | 11 +++++++++-- gnu/installer/newt/wifi.scm | 3 ++- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/gnu/installer/newt/ethernet.scm b/gnu/installer/newt/ethernet.scm index ba5e222a37..ecd22efbb2 100644 --- a/gnu/installer/newt/ethernet.scm +++ b/gnu/installer/newt/ethernet.scm @@ -77,7 +77,7 @@ connection is pending." #:title (G_ "Ethernet connection") #:listbox-items services #:listbox-item->text ethernet-service->text - #:listbox-height (min (+ (length services) 2) 10) + #:listbox-height (min (+ (length services) 2) 5) #:button-text (G_ "Exit") #:button-callback-procedure (lambda _ diff --git a/gnu/installer/newt/network.scm b/gnu/installer/newt/network.scm index 461d5d99c0..4af7143d63 100644 --- a/gnu/installer/newt/network.scm +++ b/gnu/installer/newt/network.scm @@ -80,7 +80,7 @@ network devices were found. Do you want to continue anyway?")) #:title (G_ "Internet access") #:listbox-items items #:listbox-item->text technology->text - #:listbox-height (min (+ (length items) 2) 10) + #:listbox-height (min (+ (length items) 2) 5) #:button-text (G_ "Exit") #:button-callback-procedure (lambda _ diff --git a/gnu/installer/newt/page.scm b/gnu/installer/newt/page.scm index 1d6b9979b4..4209674c28 100644 --- a/gnu/installer/newt/page.scm +++ b/gnu/installer/newt/page.scm @@ -32,7 +32,9 @@ #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) #:use-module (newt) - #:export (draw-info-page + #:export (default-listbox-height + + draw-info-page draw-connecting-page run-input-page run-error-page @@ -168,6 +170,10 @@ Like 'run-form', return two values: the exit reason, and an \"argument\"." (_ (values reason argument)))))) +(define (default-listbox-height) + "Return the default listbox height." + (max 5 (- (screen-rows) 20))) + (define (draw-info-page text title) "Draw an informative page with the given TEXT as content. Set the title of this page to TITLE." @@ -339,7 +345,8 @@ of the page is set to TITLE." (info-textbox-width 50) listbox-items listbox-item->text - (listbox-height 20) + (listbox-height + (default-listbox-height)) (listbox-default-item #f) (listbox-allow-multiple? #f) (sort-listbox-items? #t) diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm index 3fd5756b99..f5d8f1fdbf 100644 --- a/gnu/installer/newt/wifi.scm +++ b/gnu/installer/newt/wifi.scm @@ -165,7 +165,8 @@ of records present in LISTBOX." (define service-name-max-length (make-parameter 20)) ;; Height of the listbox displaying wifi services. -(define wifi-listbox-height (make-parameter 20)) +(define wifi-listbox-height (make-parameter + (default-listbox-height))) ;; Information textbox width. (define info-textbox-width (make-parameter 40)) -- 2.29.2 --=-=-=--