From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KIdGN+oFq1+/VQAA0tVLHw (envelope-from ) for ; Tue, 10 Nov 2020 21:28:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uGcMM+oFq1+oTwAAB5/wlQ (envelope-from ) for ; Tue, 10 Nov 2020 21:28:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CD729403A8 for ; Tue, 10 Nov 2020 21:28:10 +0000 (UTC) Received: from localhost ([::1]:46536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcbBR-0001EY-Ht for larch@yhetil.org; Tue, 10 Nov 2020 16:28:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcbBK-0001EF-0l for bug-guix@gnu.org; Tue, 10 Nov 2020 16:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55873) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcbBJ-0007Uc-Ns for bug-guix@gnu.org; Tue, 10 Nov 2020 16:28:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcbBJ-0006fd-Kx for bug-guix@gnu.org; Tue, 10 Nov 2020 16:28:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44491: Support GUIX_DISABLE_NETWORK_TESTS environment variable Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Nov 2020 21:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44491 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Vagrant Cascadian Received: via spool by 44491-submit@debbugs.gnu.org id=B44491.160504362225570 (code B ref 44491); Tue, 10 Nov 2020 21:28:01 +0000 Received: (at 44491) by debbugs.gnu.org; 10 Nov 2020 21:27:02 +0000 Received: from localhost ([127.0.0.1]:39186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcbAL-0006eM-Vc for submit@debbugs.gnu.org; Tue, 10 Nov 2020 16:27:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcbAK-0006dr-CX for 44491@debbugs.gnu.org; Tue, 10 Nov 2020 16:27:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41798) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcbAE-0007P5-Rb; Tue, 10 Nov 2020 16:26:54 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46972 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcbAC-0000X2-9H; Tue, 10 Nov 2020 16:26:53 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87k0uy6um8.fsf@yucca> <87y2jbu4gx.fsf@gnu.org> <87k0utt6zt.fsf@yucca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 20 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 10 Nov 2020 22:26:49 +0100 In-Reply-To: <87k0utt6zt.fsf@yucca> (Vagrant Cascadian's message of "Tue, 10 Nov 2020 10:13:42 -0800") Message-ID: <87wnysnbs6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44491@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: Z/ctDlMz9A7o Vagrant Cascadian skribis: > On 2020-11-08, Ludovic Court=C3=A8s wrote: >> Vagrant Cascadian skribis: >> >>> If this could be considered for the upcoming 1.2 release, that would be >>> appreciated, though I can also carry the patches in Debian... >> >> Yay! It should be doable, let=E2=80=99s see. > > It seems like a simpler workaround is to pass RES_OPTIONS=3Dattempts:0, > which should disable name resolution, and thus the network checks will > fail. > > With the RES_OPTIONS workaround, the changes to guix/tests.scm > network-reachable are no longer needed ... i think. :) Oooh nice, the wonders of glibc! > Might still be worth refactoring some of *.sh tests to use common > functions, since the code is basically copied and pasted in several > different places. Yes, that=E2=80=99s still a good idea. Would you like to adjust your patch accordingly? > I suspect there are some additional tests that should check for network, > but that is probably a separate bug once they have been identified. OK! Thanks, Ludo=E2=80=99.