From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id INOMICiy+F/uAwAA0tVLHw (envelope-from ) for ; Fri, 08 Jan 2021 19:27:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aOhgHCiy+F+qAQAA1q6Kng (envelope-from ) for ; Fri, 08 Jan 2021 19:27:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2143D940509 for ; Fri, 8 Jan 2021 19:27:36 +0000 (UTC) Received: from localhost ([::1]:43964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxxQ6-0005u9-UO for larch@yhetil.org; Fri, 08 Jan 2021 14:27:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxxEx-0004m0-Lb for bug-guix@gnu.org; Fri, 08 Jan 2021 14:16:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxxEw-0000be-HG for bug-guix@gnu.org; Fri, 08 Jan 2021 14:16:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxxEw-0003nC-DO for bug-guix@gnu.org; Fri, 08 Jan 2021 14:16:02 -0500 Subject: bug#30116: [PATCH] `substitute' crashes when file contains NUL characters (core-updates) Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Fri, 08 Jan 2021 19:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30116 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Mark H Weaver Mail-Followup-To: 30116@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 30116-done@debbugs.gnu.org id=D30116.161013330614504 (code D ref 30116); Fri, 08 Jan 2021 19:16:02 +0000 Received: (at 30116-done) by debbugs.gnu.org; 8 Jan 2021 19:15:06 +0000 Received: from localhost ([127.0.0.1]:50718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxxE1-0003lp-Ok for submit@debbugs.gnu.org; Fri, 08 Jan 2021 14:15:06 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:43360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxxE0-0003kv-44 for 30116-done@debbugs.gnu.org; Fri, 08 Jan 2021 14:15:04 -0500 Received: by mail-qt1-f174.google.com with SMTP id 2so7282164qtt.10 for <30116-done@debbugs.gnu.org>; Fri, 08 Jan 2021 11:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BXJnqTFpS6EMwn3PyMm/N+jW9oyv7OcQALm/P0KaU7w=; b=Gkd0XtVU6jC7pIt47ukUHfd5jbHElqUNsW4L6WbbiwTNqKEBKFAT+4Qz4sC+Zb0pUr 2NiipvzsXeRjMdS1UxfjLGieneYoVwPrxfdDJoZ/S91e0+fd7zXX7brbE3JwaTRyqdPL TdelogybjEEYIUCqFZOfpmWZqkhU7uy900UMT0SliHZDy+kgPH9WiHJMRGIBltKnDd8r XchwZhYUt+IrHAy5VVcXrh1e8vMYxWf2FdffNZKrRnX7el10GdVryV84TS9oqeUzZ9ks fWcPs2DVNRa4SJ7fOJqjMeITCjjcTjAPzlUIZE9BA0hcM+Iuz1dm/m04Y4kcHqWb73hd pM1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BXJnqTFpS6EMwn3PyMm/N+jW9oyv7OcQALm/P0KaU7w=; b=lUy1cLxkusgfKB6UJomnwL3GXabb4mh0gCCbGeribbjy8Kb+Qy0c+zSwaBC/MwEhr2 3Yz/s0Bp3ppVhBJQz8fpBaLzwxfm+JBAYdlQY7uf+U8+S+OtF/VbQlMF6EfjVBcJaBUA q61DoOKBefAQYgpXyAwdIunhRdI/smubuHo/B1LhBGl3BisnDGVH0DmfWJ1P0ba3rOz/ W0jx18pa6itra6Zi4sZSVrEIWm35es9BN2KwYENIPlElXtE8Y/o/YCiu53sKKdkjSrjT oMdELS+92GH/4cdw15LnNIdsCx32AbwUYSCtM2v3cVQqyWfTTnBN/Vc9nji/3rmt2fWo VuHA== X-Gm-Message-State: AOAM532e6/1QsV3/+HMYSQ3Hof5Sl/T/RpvCJppK7QuGTu2DmLItRvGm RLXRnsgITGsdLfJnFrhSzWvkEB7SU0o= X-Google-Smtp-Source: ABdhPJziVeh7VpQYB1tpbpEQ1dpoxWLkpQPzzLoch8cW7Owd4eV9udwwZ5dHtdFgv+b5PFpHsJRcGA== X-Received: by 2002:ac8:5ed5:: with SMTP id s21mr5088172qtx.114.1610133298384; Fri, 08 Jan 2021 11:14:58 -0800 (PST) Received: from hurd (dsl-236-123-170.b2b2c.ca. [207.236.123.170]) by smtp.gmail.com with ESMTPSA id a9sm5225230qkk.39.2021.01.08.11.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 11:14:57 -0800 (PST) From: Maxim Cournoyer References: <87r2qrc3mq.fsf@gmail.com> <87k1wjc35d.fsf_-_@gmail.com> <87r2l9q294.fsf@netris.org> <87tvq2smpm.fsf@gmail.com> <87d0wq3u8f.fsf@netris.org> Date: Fri, 08 Jan 2021 14:14:56 -0500 In-Reply-To: <87d0wq3u8f.fsf@netris.org> (Mark H. Weaver's message of "Sun, 17 Jun 2018 00:36:00 -0400") Message-ID: <87wnwn5jgv.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 30116-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=Gkd0XtVU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 2143D940509 X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7WDSuzgR46WZ Hello Mark, I was recently reminded of this bug by a new encounter; at last wrote a test for your proposed fix, and it appear to work as intended! I've committed it on your behalf in commit 485ac28235 on the core-updates branch. Closing! Thank you for the clever hack :-) Maxim